Skip to content

feat(feature): resolve legacy IDs during dependency resolution#206

Merged
skevetter merged 1 commit into
mainfrom
feat/devsy-036-legacy-id-resolution
May 4, 2026
Merged

feat(feature): resolve legacy IDs during dependency resolution#206
skevetter merged 1 commit into
mainfrom
feat/devsy-036-legacy-id-resolution

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

Implements legacy ID lookup during feature dependency resolution. When a feature's dependsOn references an old/legacy ID that no longer exists as a primary feature, the resolver now checks the legacyIds field of all known features to find the current feature that owns that legacy alias. This prevents resolution failures when features are renamed while maintaining backward compatibility through their legacyIds declarations.

  • Adds buildLegacyIDMap() helper that maps each legacy ID to its current feature's ConfigID
  • Integrates legacy lookup into resolveFeatureDependency() between the primary lookup and the fetch attempt
  • Includes unit tests for the map builder and resolution logic
  • Adds E2E testdata and test case for legacy ID resolution via dependsOn

When a feature's dependsOn references an old/legacy ID, the resolver now
checks the legacyIds field of all known features before attempting to
fetch from a registry. This maps deprecated feature names to their
current counterparts without requiring registry-level redirects.
@netlify

netlify Bot commented May 4, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit c53a6c7
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69f88eb35a130c00083c9589

@coderabbitai

coderabbitai Bot commented May 4, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 54 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f356d82a-f30a-40f5-88d1-bcf6acd3a354

📥 Commits

Reviewing files that changed from the base of the PR and between d2ca833 and c53a6c7.

📒 Files selected for processing (9)
  • cmd/runusercommands.go
  • e2e/tests/up-features/testdata/docker-features-legacy-id-resolution/.devcontainer.json
  • e2e/tests/up-features/testdata/docker-features-legacy-id-resolution/features/consumer-feature/devcontainer-feature.json
  • e2e/tests/up-features/testdata/docker-features-legacy-id-resolution/features/consumer-feature/install.sh
  • e2e/tests/up-features/testdata/docker-features-legacy-id-resolution/features/current-feature/devcontainer-feature.json
  • e2e/tests/up-features/testdata/docker-features-legacy-id-resolution/features/current-feature/install.sh
  • e2e/tests/up-features/up_features.go
  • pkg/devcontainer/feature/extend.go
  • pkg/devcontainer/feature/extend_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 53 minutes and 54 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/l label May 4, 2026
@skevetter
skevetter marked this pull request as ready for review May 4, 2026 12:20
@skevetter
skevetter enabled auto-merge (squash) May 4, 2026 12:20
@skevetter
skevetter merged commit f9dc6e3 into main May 4, 2026
183 of 186 checks passed
@skevetter
skevetter deleted the feat/devsy-036-legacy-id-resolution branch May 4, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant