Skip to content

feat(cmd): add --update-remote-user-uid-default flag to up command#208

Merged
skevetter merged 3 commits into
mainfrom
feat/up-update-remote-user-uid-default
May 4, 2026
Merged

feat(cmd): add --update-remote-user-uid-default flag to up command#208
skevetter merged 3 commits into
mainfrom
feat/up-update-remote-user-uid-default

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Adds --update-remote-user-uid-default flag to the up command accepting on or off
  • When devcontainer.json does not set updateRemoteUserUID, the CLI flag value is used as the default (previously always defaulted to true)
  • When devcontainer.json explicitly sets updateRemoteUserUID, that value takes precedence over the CLI flag
  • Includes unit tests for flag parsing, validation, and the shouldUpdateUserUID logic precedence
  • Includes E2E test skeleton for the flag
  • Fixes pre-existing build error in cmd/runusercommands.go (missing warnings parameter)

Adds a CLI flag that provides a default value for updateRemoteUserUID
when devcontainer.json does not specify it. Accepts "on" or "off".
When devcontainer.json explicitly sets updateRemoteUserUID, that value
takes precedence over the CLI flag.

Also fixes pre-existing build error in runusercommands.go (missing
warnings parameter in WriteResultJSON call).
@netlify

netlify Bot commented May 4, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 5329a67
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69f8c73d8585c70007d0934c

@coderabbitai

coderabbitai Bot commented May 4, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 55 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: db5b8538-c121-41e4-8557-3088f4563bb9

📥 Commits

Reviewing files that changed from the base of the PR and between d2ca833 and ab8d90e.

📒 Files selected for processing (7)
  • cmd/runusercommands.go
  • cmd/up.go
  • cmd/up_update_remote_user_uid_test.go
  • e2e/tests/up/update_remote_user_uid.go
  • pkg/driver/docker/docker.go
  • pkg/driver/docker/docker_test.go
  • pkg/provider/workspace.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 22 minutes and 55 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/l label May 4, 2026
@skevetter
skevetter marked this pull request as ready for review May 4, 2026 12:37
@skevetter
skevetter enabled auto-merge (squash) May 4, 2026 12:37
skevetter added 2 commits May 4, 2026 07:51
Addresses goconst lint violations introduced in PR #208:
- "on"/"off" for UpdateRemoteUserUIDDefault replaced with exported constants
- "docker" command string in e2e test extracted to local constant
- "vscode" remote user string in docker driver tests extracted to constant
@github-actions github-actions Bot added size/xs and removed size/l labels May 4, 2026
@skevetter
skevetter merged commit 14e6944 into main May 4, 2026
135 of 142 checks passed
@skevetter
skevetter deleted the feat/up-update-remote-user-uid-default branch May 4, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant