feat(compose): validate runServices against compose file services#211
Conversation
Return a clear error listing invalid service names when runServices references services that don't exist in the docker-compose file, instead of failing with confusing errors at container start time.
✅ Deploy Preview for devsydev canceled.
|
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 37 minutes.Comment |
Summary
Adds upfront validation that each service listed in
runServicesactually exists in the referenced docker-compose file'sservices:map. Previously, typos inrunServiceswould pass silently through config loading and only fail with confusing errors at container start time. Now a clear error is returned immediately, listing all invalid service names (e.g.runServices: service(s) not found in compose file: [typo-service]).validateRunServices()inpkg/devcontainer/compose.gocalled afterLoadDockerComposeProjectreturnsrunServicesentry asserting the error message