fix(e2e): correct runServices error assertion#224
Merged
Conversation
The E2E test for invalid runServices was asserting on err.Error() which only contains the exit code, not the validation message. The validation error is written to stderr by the CLI. Check stderr directly instead.
✅ Deploy Preview for devsydev canceled.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single e2e test for invalid runServices in docker-compose scenarios was refactored to use explicit workspace setup with command execution ( ChangesE2E Test Refactoring
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skevetter
marked this pull request as ready for review
May 5, 2026 00:46
skevetter
enabled auto-merge (squash)
May 5, 2026 00:46
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
err.Error()which only contains the exit code ("exit status 1"), not the validation messageSummary by CodeRabbit