feat(compose): validate hostRequirements in Docker Compose path#247
Conversation
The Docker Compose container creation path never called ValidateHostRequirements(), unlike the single-container path. Add the advisory validation call before setupContainer so that host requirement warnings propagate through the JSON envelope.
✅ Deploy Preview for devsydev canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughIntegrates host requirement warnings validation into the Docker Compose setup flow. When running the up docker-compose command, host requirements from the dev container configuration are now validated, and any warnings are captured and passed to container setup before initialization. A new e2e test verifies this integration. ChangesHost Requirements Warning Integration for Docker Compose
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
ValidateHostRequirements()call to the Docker Compose container creation path (pkg/devcontainer/compose.go), matching the existing behavior in the single-container path (single.go:225-229).setupContainerParams.hostWarningsinto the JSON result envelope.up-docker-compose-host-requirementslabel) that verifies CPU warnings appear in the JSON envelope when using Docker Compose withhostRequirements.cpusset above host capacity.Reference: https://containers.dev/implementors/reference/ (hostRequirements section)
Summary by CodeRabbit
New Features
Tests