Skip to content

fix(delivery): ensure target dir exists before docker cp#269

Merged
skevetter merged 1 commit into
mainfrom
85a4-hotfix-delivery-tests
May 13, 2026
Merged

fix(delivery): ensure target dir exists before docker cp#269
skevetter merged 1 commit into
mainfrom
85a4-hotfix-delivery-tests

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • RemoteDockerDelivery.DeliverPostStart now runs mkdir -p inside the container before docker cp, preventing failures on minimal images (e.g. busybox:latest) that lack /usr/local/bin/
  • Root cause: PR feat(delivery): add KubernetesDelivery strategy for K8s agent binary injection #267 added the delivery e2e test label to CI in the same PR, but auto-merge triggered before that new job could run — so this bug shipped to main untested
  • Both delivery e2e tests (LocalDockerDelivery + RemoteDockerDelivery) pass locally after this fix

…oteDockerDelivery

The busybox and other minimal container images lack /usr/local/bin/,
causing docker cp to fail with "Could not find the file". Run mkdir -p
inside the container before copying the agent binary.
@netlify

netlify Bot commented May 13, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 1f22616
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a04870c2eca820008dbe34f

@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 48 minutes and 33 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 05611341-6aea-4902-8b7a-950f21bbb699

📥 Commits

Reviewing files that changed from the base of the PR and between 918ed99 and 1f22616.

📒 Files selected for processing (1)
  • pkg/agent/delivery/remote_docker.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
skevetter merged commit b39c2b4 into main May 13, 2026
100 of 102 checks passed
@skevetter
skevetter deleted the 85a4-hotfix-delivery-tests branch May 13, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant