Skip to content

test(e2e): expand Podman e2e test parity with Docker#283

Closed
skevetter wants to merge 3 commits into
mainfrom
70bd-0e6a-ws-a-e2e-parity
Closed

test(e2e): expand Podman e2e test parity with Docker#283
skevetter wants to merge 3 commits into
mainfrom
70bd-0e6a-ws-a-e2e-parity

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Add 14 new Podman e2e test scenarios to both rootless and rootful modes (28 new ginkgo.It blocks) in e2e/tests/up/provider_podman.go
  • Achieves parity with Docker provider tests for all SSH-verifiable scenarios: variables substitution, variable defaults, remoteEnv null, custom image, custom image skip build, extra devcontainer merge/override, postStartCommand restart, waitFor deferred lifecycle, postAttach nonblocking/every-attach, initializeCommand parallel, secrets-file injection, and multi devcontainer selection
  • Docker-API-specific tests (container inspection, security opts, mount details, id-labels) are intentionally excluded as they require Docker Go SDK not available in Podman context

…ith Docker

Port variables substitution, variable defaults, remoteEnv null, custom image,
custom image skip build, extra devcontainer merge/override, postStartCommand
restart, waitFor deferred lifecycle, postAttach nonblocking, postAttach every
attach, initializeCommand parallel, secrets-file injection, and multi
devcontainer selection tests to both rootless and rootful Podman contexts.
@netlify

netlify Bot commented May 14, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 6e64750
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a05b4a67ddf3b0008226e87

@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9660f85d-1ec0-4e86-94d9-93681e0efbdc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter

Copy link
Copy Markdown
Contributor Author

Superseded by PR #284 which was merged for DEVSY-100 (Podman e2e test parity). This PR was an earlier attempt from a different worktree branch.

@skevetter skevetter closed this May 14, 2026
skevetter added a commit that referenced this pull request May 14, 2026
…ring (#283) (#287)

Per the devcontainer spec, setting workspaceMount to "" should suppress
the default workspace mount. Previously the string type could not
distinguish between omitted and explicitly empty, so "" fell through
to the default bind mount.

Change WorkspaceMount from string to *string so nil means omitted
(use default mount) and *"" means suppress mount entirely.
@devsy-app devsy-app Bot mentioned this pull request May 16, 2026
@skevetter
skevetter deleted the 70bd-0e6a-ws-a-e2e-parity branch May 17, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant