Skip to content

fix(daemon): remove hardcoded ShutdownAction fallback, trust merge layer#286

Merged
skevetter merged 1 commit into
mainfrom
0762-e124-ws-a-shutdown-fix
May 14, 2026
Merged

fix(daemon): remove hardcoded ShutdownAction fallback, trust merge layer#286
skevetter merged 1 commit into
mainfrom
0762-e124-ws-a-shutdown-fix

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Removed the hardcoded ShutdownActionStopContainer fallback in pkg/daemon/agent/daemon.go:64 that overrode the merge layer's context-dependent default
  • The merge layer (pkg/devcontainer/config/merge.go:143-152) already correctly differentiates: compose workspaces → stopCompose, image workspaces → stopContainer, explicit user config → respected
  • The daemon now trusts the merge layer's value directly instead of re-defaulting
  • Updated unit test to reflect pass-through behavior

…lting

The daemon's safety-net fallback to StopContainer masked the
context-dependent default set by merge.go (StopCompose for compose
workspaces, StopContainer for image workspaces). Remove the conditional
and use mergedConfig.ShutdownAction directly, since the merge layer
guarantees it is always populated.
@netlify

netlify Bot commented May 14, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev ready!

Name Link
🔨 Latest commit c5debda
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a0604dfe2c7b2000817e140
😎 Deploy Preview https://deploy-preview-286--devsydev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 34 minutes and 11 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cfee22c7-95dc-40bc-ab16-fbeb75806cb5

📥 Commits

Reviewing files that changed from the base of the PR and between ab8d905 and c5debda.

📒 Files selected for processing (2)
  • pkg/daemon/agent/daemon.go
  • pkg/daemon/agent/daemon_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
skevetter marked this pull request as ready for review May 14, 2026 18:07
@skevetter
skevetter enabled auto-merge (squash) May 14, 2026 18:07
@skevetter
skevetter merged commit 32e062a into main May 14, 2026
100 of 104 checks passed
@skevetter
skevetter deleted the 0762-e124-ws-a-shutdown-fix branch May 14, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant