Skip to content

fix(ci): fix Netlify deploy and Flatpak upload in release workflow#321

Merged
skevetter merged 1 commit into
mainfrom
0bd9-74a0-fix-release-netlify-flatpak
May 18, 2026
Merged

fix(ci): fix Netlify deploy and Flatpak upload in release workflow#321
skevetter merged 1 commit into
mainfrom
0bd9-74a0-fix-release-netlify-flatpak

Conversation

@skevetter

@skevetter skevetter commented May 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix "Deploy Update Metadata to Netlify" failure: latest netlify-cli removed --config flag. Added working-directory: sites/dl-devsy-sh so netlify.toml is auto-discovered, changed --dir to relative public.
  • Fix "Build Flatpak" failure: added permissions: contents: write to build-flatpak job so softprops/action-gh-release@v3 can upload assets to the GitHub release.

Both failures caused "Publish Prerelease" to be skipped in release run 26009097494 (tag v1.3.0-rc.1).

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to enhance deployment reliability and process optimization.

Review Change Stack

@netlify

netlify Bot commented May 18, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 9f90b63
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a0a808844020d0008ecc0b3

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 756e8cf0-d25a-4783-b50c-c7b6c0e1ee91

📥 Commits

Reviewing files that changed from the base of the PR and between 8e489e7 and 9f90b63.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The release workflow is updated in two ways: the Flatpak build job now explicitly declares contents: write permission at the job level, and the Netlify metadata deployment step changes from using a --config argument to using --dir=public for direct directory-based deployment.

Changes

Release Workflow Configuration

Layer / File(s) Summary
Flatpak permissions and Netlify deployment configuration
.github/workflows/release.yml
Build-flatpak job adds explicit permissions: contents: write. Netlify deploy command changes from --config=netlify.toml to --dir=public to deploy directly from the public directory.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main changes: fixing Netlify deployment and Flatpak upload issues in the release workflow, which matches the primary objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
skevetter marked this pull request as ready for review May 18, 2026 03:00
@skevetter
skevetter enabled auto-merge (squash) May 18, 2026 03:00
@skevetter
skevetter merged commit 642dc1c into main May 18, 2026
50 checks passed
@skevetter
skevetter deleted the 0bd9-74a0-fix-release-netlify-flatpak branch May 18, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant