refactor(cli)!: polish ide subcommand and move workspace set-ide - #470
Merged
Conversation
- Use cobra.ExactArgs(1) and add <ide> positional to Use: strings for ide use/set/get; replace hand-rolled arg checks. - Add ValidArgsFunction tab completion for the <ide> argument. - ide use: log confirmation when the default IDE is set. - ide set: error when invoked without --option (was a silent no-op). - ide list: mark the default IDE with '*' instead of true/false. - ide get (options): use MarshalIndent and write via fmt.Fprintln(os.Stdout) to match the sibling list command. - Move per-workspace IDE assignment from 'ide set --workspace <name>' to a dedicated 'workspace set-ide <workspace> <ide>' command so the noun matches the state being mutated; update the desktop IPC handler accordingly. BREAKING CHANGE: 'devsy ide set --workspace <name>' is removed. Use 'devsy workspace set-ide <workspace> <ide>' instead.
✅ Deploy Preview for devsydev canceled.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skevetter
marked this pull request as ready for review
May 31, 2026 16:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devsy idesubcommand UX:cobra.ExactArgs(1)and put<ide>inUse:strings foruse/set/get.<ide>positional viaValidArgsFunction.ide uselogs a confirmation when the default is set.ide seterrors instead of silently doing nothing when no--optionis passed.ide listmarks the default IDE with*instead of atrue/falsecolumn.ide getusesMarshalIndentandfmt.Fprintln(os.Stdout, ...)to match its siblinglistcommand.ide set --workspaceinto a dedicatedworkspace set-ide <workspace> <ide>command so the noun matches the state being mutated. The desktop IPC handler is updated accordingly; the renderer-side channel name (workspace_set_ide) was already correct.BREAKING:
devsy ide set --workspace <name>is removed. Usedevsy workspace set-ide <workspace> <ide>instead.