Skip to content

fix(build): bake devcontainer.metadata LABEL into built images#82

Merged
skevetter merged 1 commit into
mainfrom
sk-fix-metadata-label-bake
Apr 23, 2026
Merged

fix(build): bake devcontainer.metadata LABEL into built images#82
skevetter merged 1 commit into
mainfrom
sk-fix-metadata-label-bake

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • BuildOptions.Labels was correctly populated with the devcontainer.metadata label but never passed as --label flags to the docker buildx build command
  • Added appendLabels helper (with sorted keys for deterministic output) and wired it into buildDockerBuildxArgs, matching the existing pattern used by appendBuildArgsAndContexts
  • The buildkit code paths already handled labels correctly; this fix closes the gap for the docker buildx path

@netlify

netlify Bot commented Apr 23, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 61d5465
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69ea4363448e15000832d0a3

@coderabbitai

coderabbitai Bot commented Apr 23, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 37 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 26 minutes and 37 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7da88183-bf63-4108-8ea2-2914dd491623

📥 Commits

Reviewing files that changed from the base of the PR and between 93e0da3 and 61d5465.

📒 Files selected for processing (1)
  • pkg/driver/docker/build.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
skevetter merged commit 8d6d7c8 into main Apr 23, 2026
83 of 88 checks passed
@skevetter
skevetter deleted the sk-fix-metadata-label-bake branch April 23, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant