fix(config): resolve undefined variables to empty string#96
Conversation
…iteral
Per the devcontainer spec, unresolvable variables like ${someUnknownVar}
should become empty strings. The replaceWithContext and
replaceWithContainerEnv functions were returning the literal match
string, leaving ${var} tokens in the output. Now unknown variables
resolve to "" while ${containerEnv:...} references are still preserved
for the later SubstituteContainerEnv pass.
✅ Deploy Preview for devsydev canceled.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 19 minutes and 20 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
${someUnknownVar}should be replaced with an empty string""instead of remaining as literals in the outputreplaceWithContextto add an explicitcontainerEnvcase (preserved for the laterSubstituteContainerEnvpass) and changed thedefaultcase to return""replaceWithContainerEnvdefault case to return""for any remaining unresolved variables after both substitution passescontainerEnvis preserved, andreplaceWithContainerEnvhandles unknown varsdocker-variables-unknowntestdata confirming unknown variables become empty in a real workspace