From f61b1cdbcd0ee17a12014aa2172ae8109b137cc0 Mon Sep 17 00:00:00 2001 From: Samuel K Date: Sat, 25 Apr 2026 14:25:03 -0500 Subject: [PATCH 1/2] fix(ux): replace %w with %v in log format strings The %w verb only works with fmt.Errorf for error wrapping. In log.Errorf calls it produces garbled output like %!w(*errors.errorString=&{...}). --- cmd/ssh.go | 2 +- pkg/daemon/platform/local_server.go | 2 +- pkg/loftconfig/client.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/ssh.go b/cmd/ssh.go index dfb42d0ee..1e79c6f49 100644 --- a/cmd/ssh.go +++ b/cmd/ssh.go @@ -798,7 +798,7 @@ func startSSHKeepAlive( case <-ticker.C: _, _, err := client.SendRequest("keepalive@openssh.com", true, nil) if err != nil { - log.Errorf("Failed to send keepalive: %w", err) + log.Errorf("Failed to send keepalive: %v", err) } } } diff --git a/pkg/daemon/platform/local_server.go b/pkg/daemon/platform/local_server.go index abf3a7dd0..f90b56fba 100644 --- a/pkg/daemon/platform/local_server.go +++ b/pkg/daemon/platform/local_server.go @@ -603,7 +603,7 @@ func (l *localServer) watchWorkspaces( fmt.Errorf("failed to watch workspaces: %w", err).Error(), http.StatusInternalServerError, ) - log.Errorf("watch workspaces: %w", err) + log.Errorf("watch workspaces: %v", err) return } } diff --git a/pkg/loftconfig/client.go b/pkg/loftconfig/client.go index 072c57af1..de5a4ad5b 100644 --- a/pkg/loftconfig/client.go +++ b/pkg/loftconfig/client.go @@ -18,7 +18,7 @@ func GetDevsyConfig(context, provider string, port int) (*client.Config, error) rawJson, err := json.Marshal(request) if err != nil { - log.Errorf("Error parsing request: %w", err) + log.Errorf("Error parsing request: %v", err) return nil, err } From ab04e0fe07e7226bc4a5b4d74fd70ced37099e7c Mon Sep 17 00:00:00 2001 From: Samuel K Date: Sat, 25 Apr 2026 14:30:23 -0500 Subject: [PATCH 2/2] fix(ux): replace %w with %v in log.Debugf format strings Two additional log.Debugf calls in pkg/loftconfig/config.go used %w, which produces garbled output in log functions. --- pkg/loftconfig/config.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/loftconfig/config.go b/pkg/loftconfig/config.go index a7a07896f..a603f455a 100644 --- a/pkg/loftconfig/config.go +++ b/pkg/loftconfig/config.go @@ -21,7 +21,7 @@ func AuthDevsyCliToPlatform(config *client.Config) error { out, err := cmd.CombinedOutput() if err != nil { log.Debugf( - "Failed executing `%s pro login`: %w, output: %s", + "Failed executing `%s pro login`: %v, output: %s", pkgconfig.BinaryName, err, out, @@ -47,7 +47,7 @@ func AuthVClusterCliToPlatform(config *client.Config) error { cmd := exec.Command("vcluster", "login", "--access-key", config.AccessKey, config.Host) out, err := cmd.CombinedOutput() if err != nil { - log.Debugf("Failed executing `vcluster login` : %w, output: %s", err, out) + log.Debugf("Failed executing `vcluster login` : %v, output: %s", err, out) return fmt.Errorf("error executing 'vcluster login' command: %w", err) }