From 808a90b52eb4111812a83851faa214f51ff96e50 Mon Sep 17 00:00:00 2001 From: Samuel K Date: Sat, 25 Apr 2026 14:30:12 -0500 Subject: [PATCH 1/2] fix(ux): propagate swallowed errors in workspace resolution resolveWorkspace was discarding findWorkspace errors with _, causing misleading "doesn't exist" messages when the real error was a network failure or permission denied. Also promotes workdir resolution error logging from Debug to Warn for user visibility. --- cmd/ssh.go | 2 +- pkg/workspace/workspace.go | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/cmd/ssh.go b/cmd/ssh.go index dfb42d0ee..57387aa3d 100644 --- a/cmd/ssh.go +++ b/cmd/ssh.go @@ -624,7 +624,7 @@ func resolveMergedWorkspaceFolder( result, err := provider.LoadWorkspaceResult(workspaceConfig.Context, workspaceConfig.ID) if err != nil { - log.Debugf("Error loading workspace result for workdir resolution: %v", err) + log.Warnf("Error loading workspace result for workdir resolution: %v", err) return "" } if result == nil || result.MergedConfig == nil { diff --git a/pkg/workspace/workspace.go b/pkg/workspace/workspace.go index cf95fe362..8126537fd 100644 --- a/pkg/workspace/workspace.go +++ b/pkg/workspace/workspace.go @@ -236,7 +236,10 @@ func resolveWorkspace( // check if we have no args if len(params.Args) == 0 { if params.DesiredID != "" { - workspace, _ := findWorkspace(ctx, devsyConfig, nil, params.DesiredID, params.Owner) + workspace, err := findWorkspace(ctx, devsyConfig, nil, params.DesiredID, params.Owner) + if err != nil { + return nil, nil, nil, fmt.Errorf("find workspace: %w", err) + } if workspace == nil { return nil, nil, nil, fmt.Errorf("workspace %s doesn't exist", params.DesiredID) } From a130cd3ed9edc0bed4cdde9e590fc2300faa25f3 Mon Sep 17 00:00:00 2001 From: Samuel K Date: Sat, 25 Apr 2026 14:30:23 -0500 Subject: [PATCH 2/2] fix(ux): replace %w with %v in log.Debugf format strings Two additional log.Debugf calls in pkg/loftconfig/config.go used %w, which produces garbled output in log functions. --- pkg/loftconfig/config.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/loftconfig/config.go b/pkg/loftconfig/config.go index a7a07896f..a603f455a 100644 --- a/pkg/loftconfig/config.go +++ b/pkg/loftconfig/config.go @@ -21,7 +21,7 @@ func AuthDevsyCliToPlatform(config *client.Config) error { out, err := cmd.CombinedOutput() if err != nil { log.Debugf( - "Failed executing `%s pro login`: %w, output: %s", + "Failed executing `%s pro login`: %v, output: %s", pkgconfig.BinaryName, err, out, @@ -47,7 +47,7 @@ func AuthVClusterCliToPlatform(config *client.Config) error { cmd := exec.Command("vcluster", "login", "--access-key", config.AccessKey, config.Host) out, err := cmd.CombinedOutput() if err != nil { - log.Debugf("Failed executing `vcluster login` : %w, output: %s", err, out) + log.Debugf("Failed executing `vcluster login` : %v, output: %s", err, out) return fmt.Errorf("error executing 'vcluster login' command: %w", err) }