From 07caaff04cc33de5271c202f603444bfdc65ba7d Mon Sep 17 00:00:00 2001 From: Samuel K Date: Mon, 4 May 2026 18:53:06 -0500 Subject: [PATCH] fix(e2e): correct runServices error assertion The E2E test for invalid runServices was asserting on err.Error() which only contains the exit code, not the validation message. The validation error is written to stderr by the CLI. Check stderr directly instead. --- e2e/tests/up-docker-compose/up_docker_compose.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/e2e/tests/up-docker-compose/up_docker_compose.go b/e2e/tests/up-docker-compose/up_docker_compose.go index 7811effb8..397e592bb 100644 --- a/e2e/tests/up-docker-compose/up_docker_compose.go +++ b/e2e/tests/up-docker-compose/up_docker_compose.go @@ -503,12 +503,16 @@ var _ = ginkgo.Describe( }, ginkgo.SpecTimeout(framework.TimeoutShort())) ginkgo.It("invalid runServices returns error", func(ctx context.Context) { - _, _, err := tc.setupAndStartWorkspace( - ctx, + tempDir, err := setupWorkspace( "tests/up-docker-compose/testdata/docker-compose-run-services-invalid", + tc.initialDir, tc.f, ) + framework.ExpectNoError(err) + _, stderr, err := tc.f.ExecCommandCapture(ctx, []string{ + "up", "--debug", "--ide", "none", tempDir, + }) gomega.Expect(err).To(gomega.HaveOccurred()) - gomega.Expect(err.Error()).To(gomega.ContainSubstring("nonexistent-service")) + gomega.Expect(stderr).To(gomega.ContainSubstring("nonexistent-service")) }, ginkgo.SpecTimeout(framework.TimeoutShort())) ginkgo.It("user lookup with no remoteUser", func(ctx context.Context) {