Skip to content

Commit e15bcf0

Browse files
committed
fix: collect portable exe by pattern instead of hardcoded filename
electron-builder produces 'OmniRoute 1.6.9.exe' (with version) as the portable exe, not 'OmniRoute.exe'. The hardcoded check failed, returning exit code 1 and breaking every Windows build in the release workflow. Now finds the portable exe by excluding 'Setup' (NSIS installer) and blockmap files, then copies it as OmniRoute.exe for the release assets.
1 parent dbffb18 commit e15bcf0

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.github/workflows/electron-release.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,13 @@ jobs:
112112
done
113113
# Windows: also copy portable standalone exe
114114
if [ "${{ matrix.platform }}" = "windows" ]; then
115-
[ -f "OmniRoute.exe" ] && cp OmniRoute.exe ../../release-assets/
115+
for file in *.exe; do
116+
# Skip the NSIS installer (contains "Setup") and blockmap files
117+
case "$file" in *Setup*|*.blockmap) continue ;; esac
118+
[ -f "$file" ] && cp "$file" "../../release-assets/OmniRoute.exe"
119+
done
116120
fi
121+
ls -la ../../release-assets/ || true
117122
118123
- name: Upload artifacts
119124
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)