Skip to content

chore: update cpp minimum required version to c++23#46

Merged
sbillinge merged 7 commits into
diffpy:migration-nanofrom
SYMSCAE:cpp23
Jun 24, 2026
Merged

chore: update cpp minimum required version to c++23#46
sbillinge merged 7 commits into
diffpy:migration-nanofrom
SYMSCAE:cpp23

Conversation

@SYMSCAE

@SYMSCAE SYMSCAE commented Jun 21, 2026 •
edited
Loading

Copy link
Copy Markdown

This PR updates cpp language version to c++23 and replaces boost smart pointer usages with stl implementations.

@SYMSCAE SYMSCAE marked this pull request as ready for review June 21, 2026 19:18
@SYMSCAE SYMSCAE marked this pull request as draft June 21, 2026 19:26
@SYMSCAE SYMSCAE marked this pull request as ready for review June 21, 2026 19:41
@SYMSCAE

SYMSCAE commented Jun 21, 2026

Copy link
Copy Markdown
Author

@sbillinge PR ready for review. We can start migrating python bindings from this branch of libdiffpy. I've manually checked boost serializations and they've already supported std smart pointer serializations. All scons tests passed.

sbillinge
sbillinge reviewed Jun 22, 2026
View reviewed changes

@sbillinge sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really qualified to review this but it LGTM. @pavoljuhas are you able to quickly review this. For context, we are migrating from boost to nanobind for future proofing for 3.14 and on

@sbillinge sbillinge merged commit b191c66 into diffpy:migration-nano Jun 24, 2026
@sbillinge

sbillinge commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@SYMSCAE I merged. Let's push on. Tests are not running in CI in this setup. We could either modify the workflow temporarily to run on merge to migration-nano, it just paste the results of running tests on your local in a comment. I leave this to to you. If we update the workflow, also make an issue to change it back later.

@SYMSCAE SYMSCAE deleted the cpp23 branch June 24, 2026 16:55
@pavoljuhas

pavoljuhas commented Jun 25, 2026

Copy link
Copy Markdown
Member

LGTM after a quick skim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbillinge sbillinge sbillinge left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SYMSCAE @sbillinge @pavoljuhas