Occupancy grid image#822
Closed
s-desh wants to merge 2568 commits into
Closed
Conversation
leshy
requested changes
Dec 10, 2025
leshy
left a comment
Member
There was a problem hiding this comment.
just these small things, otherwise looks good
0bdf5a6 to
6fbe4eb
Compare
Member
Author
482ed81 to
7165549
Compare
ab9769c to
3e5509b
Compare
3e5509b to
90d5a91
Compare
Contributor
|
Too many files changed for review. |
1 similar comment
Contributor
|
Too many files changed for review. |
90d5a91 to
dc49a93
Compare
Contributor
|
Too many files changed for review. |
1 similar comment
Contributor
|
Too many files changed for review. |
dc49a93 to
7c2c2f8
Compare
Contributor
|
Too many files changed for review. |
1 similar comment
Contributor
|
Too many files changed for review. |
Contributor
|
Closed because it's old and it's before the rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR is one of many for encoding maps for agents. #804
Adds
Evals and Results
A dataset of floorplans (only 2 right now, with variations) are used to generate grids and evaluated on point placement and map comprehension. This dataset can be populated by adding a new floorplans with expected answers for queries.
dimos/agents2/skills/interpret_map/eval/test_map_interpretability.yamlhas queries with varying difficulty to evaluate spatial reasoning. For now, the minimum pass rate for point placement and map comprehension is set to 0.25 and 0.7 respectively.Run
For evals run
pytest -s dimos/agents2/skills/interpret_map/eval/test_map_eval.py.Examples of successful point placement results.
Go to the conference table in the office
Second room to the robot’s left along the corridor
a point immediately behind the robot
second room to the robot’s left along the corridor
Debug
debug_goal_placement_<map_id>_<query>.png. The goal placed is marked with+Adding new maps and queries for eval
map_id,image_path,robot_pose.positionin pixels andorientationundermap_comprehension_testsorpoint_placement_testsindimos/agents2/skills/interpret_map/eval/test_map_interpretability.yaml.dimos/agents2/skills/interpret_map/eval/annotate.py <image.png>to create bounding boxes and question pairs. These are saved into aquestions.yaml, copy them to main testing yaml mentioned above.Running with agents
The interpret_map_skill is to be able to pull the map / place a goal based on the query and return the world coordinates to navigate.
Run
dimos --replay run unitree-go2-agentic --extra-module interpret_map_skillIn the cli, queries like "get a goal right in front of the robot", "get a goal to the northeast side of the map" can be asked.
Few observations