Beautify Overview (Part 1)#1672
Conversation
trisyoungs
left a comment
trisyoungs
left a comment
There was a problem hiding this comment.
Definitely looking better. Just a single question on perhaps reusing property definitions in some way, but that's about it from me!
| Layout.fillHeight: true | ||
| Layout.fillWidth: true | ||
| Layout.maximumHeight: 200 | ||
| Layout.maximumWidth: 200 | ||
| Layout.preferredHeight: 100 | ||
| Layout.preferredWidth: 200 |
There was a problem hiding this comment.
Since this is repeated for all intramolecular types, can these properties be captured in a subclass / custom widget type of way?
There was a problem hiding this comment.
That'd be nice, although it seems harder to do than it sounds - I'll look into it a bit more though.
There was a problem hiding this comment.
It turns out that this is quite difficult to do, since the Layout... properties are "attached" by the RowLayout that the various intramolecular objects live in. This means we couldn't, as far as I can tell, have a base Intramolecular class with these properties that we then inherit from, as the attached properties wouldn't be defined...
There was a problem hiding this comment.
I suspected it might be! Time to move on I guess...
Co-authored-by: Adam Washington <adam.washington@stfc.ac.uk>
Co-authored-by: Adam Washington <adam.washington@stfc.ac.uk>
Co-authored-by: Adam Washington <adam.washington@stfc.ac.uk>
3 participants
This PR implements the first pass of beautification of the Overview Tab, with the main goal of ensuring that nodes are properly layed out and resized.