Change to CMakeLists.txt to allow for arm64 builds#1697
Merged
Conversation
added 2 commits
November 10, 2023 16:21
trisyoungs
approved these changes
Nov 12, 2023
rprospero
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Spitz <noella.spitz@ndw2544mac.isis.cclrc.ac.uk>
rprospero
pushed a commit
that referenced
this pull request
Apr 8, 2024
Co-authored-by: Spitz <noella.spitz@ndw2544mac.isis.cclrc.ac.uk>
rprospero
pushed a commit
that referenced
this pull request
Apr 9, 2024
Co-authored-by: Spitz <noella.spitz@ndw2544mac.isis.cclrc.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMAKE_OSX_ARCHITECTURE flag in
CMakeLists.txtis being set to "x86_64" which prevents builds for arm64. This PR changes it so that the flag will only be set to x86 if there is none specified. Part of addressing #1695.