1626 Icons 1.4#1698
Merged
Merged
Conversation
trisyoungs
force-pushed
the
1626-icons-1.4
branch
from
c5cace9 to
d4e0566
Compare
trisyoungs
requested review from
Danbr4d,
RobBuchananCompPhys,
rhinoella and
rprospero
rhinoella
approved these changes
Nov 13, 2023
Contributor
rhinoella
left a comment
rhinoella
left a comment
There was a problem hiding this comment.
Looks great! Only comment would be that dAngle is sort of an odd-one-out as it doesn't match the rest of the icons.
Member
Author
|
Fair comment, but it's easier to illustrate it with a nice picture than a diagram! Hopefully it will do the job for now. |
rprospero
pushed a commit
that referenced
this pull request
Mar 11, 2024
rprospero
pushed a commit
that referenced
this pull request
Apr 8, 2024
rprospero
pushed a commit
that referenced
this pull request
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing node icons and updates the analysis-related module icons (remove the little calculator "marker" and give them some proper design).
Closes #1626.