Fix serialisation of Species Site with TOML#1701
Merged
Merged
Conversation
That's the last TomlFailuire
rprospero
added
16
trisyoungs
approved these changes
Nov 14, 2023
Member
trisyoungs
left a comment
trisyoungs
left a comment
There was a problem hiding this comment.
Just one comment, otherwise all looks nice.
Comment on lines
+778
to
+783
| auto typeString = toml::find_or<std::string>(node, "type", "Static"); | ||
| if (typeString == "Static") | ||
| type_ = SiteType::Static; | ||
| else if (typeString == "Fragment") | ||
| type_ = SiteType::Fragment; | ||
| else if (typeString == "Dynamic") |
Member
There was a problem hiding this comment.
Rather than going to the effort of putting this string check in here it would be generally more useful to put in an EnumOptions associated with the SiteType. That would necessitate reducing it to a simple enum rather than an enum class. Small thing though, and not related to TOML, so feel free to leave or capture as a new issue.
Contributor
Author
There was a problem hiding this comment.
I've added issue #1706 to track this and I'm adding it to my master issue for putting TOML before the users.
rprospero
added a commit
that referenced
this pull request
Mar 11, 2024
rprospero
added a commit
that referenced
this pull request
Apr 8, 2024
rprospero
added a commit
that referenced
this pull request
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for Dynamic and Fragment sites has now been added. Please note that
element.descriptionstringoriginMassWeightedtoggleI'm happy to add other parameters if they are need. These were just the ones required to pass the tests.