Modify charge dialogs qml#1787
Conversation
|
Something corrupt / missing in the qml files, or at least their location as I get this error (as does the CI): |
|
@RobBuchananCompPhys An update from my machine. Upgrading my distribution has now furnished me with Qt 6.4.2 which solves all of the odd errors with text / widget colouring I was seeing. I also now understand the font scaling issue - I still see odd results when setting |
We can set this in the base D.Text class, presumably, in order to provide a consistent result? |
3db0510 to
4b1b3b5
Compare
trisyoungs
left a comment
There was a problem hiding this comment.
Looking good. Like the unit test!
I still have a question over whether we really need to stash a pointer to a ModifyChargesModel anywhere - rather, can't we just new one when we need it (see my comment)?
trisyoungs
left a comment
There was a problem hiding this comment.
Looking very nice now. Regarding the font.pointSize issue, do we then just remove that for now until we understand the (cross-platform) effects a bit better?
Also, I have pushed a small commit on to the PR which just moves the declaration of the model in gui.h to more of its own section. Felt silly explaining that and requesting a change!
Thanks @trisyoungs ! On another note, I noticed that the simulation menu also utilises |
|
@trisyoungs @RobBuchananCompPhys Here's the dialog on my machine. |
Looks promising! Shall we merge? |
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>


This PR aims to implement the three dialogs "Scale Charges", "Smooth Charges" and "Reduce Sig Figs in Charges", in QML.
I have used a generic
ModifyChargesModelto handle the resources corresponding to each operation, since all dialogs share a common, simple format of components, and similarly updated the dialog class to handle connections between all three QMLs and the model.Therefore, this supersedes (and incorporates) the work I did recently on the ScaleChargesDialog/Model.