1791 Mugglify CIF Importer#1799
Merged
Merged
Conversation
trisyoungs
force-pushed
the
1791-mugglify-cif-importer
branch
from
7e4aca5 to
290730f
Compare
Member
|
I see this is not ready for review yet, but just wanted to chime in and say I like the new look of things! A single page dialog is definitely the way to go (I got very fed up of the wizard when I was working on this stuff before!). |
Member
Author
|
Yeah, I think my view on wizards has changed to the polar opposite now - can't stand em! Particularly in the case of the CIF import, it felt like didn't give the users or the developers the best view on things. |
trisyoungs
force-pushed
the
1791-mugglify-cif-importer
branch
from
290730f to
f81da8e
Compare
trisyoungs
force-pushed
the
1791-mugglify-cif-importer
branch
from
f81da8e to
8bd65bd
Compare
rhinoella
reviewed
Feb 19, 2024
rhinoella
requested changes
Feb 19, 2024
Contributor
rhinoella
left a comment
rhinoella
left a comment
There was a problem hiding this comment.
Looks good, minor comments.
Co-authored-by: Noella Spitz <101950441+rhinoella@users.noreply.github.com>
Co-authored-by: Noella Spitz <101950441+rhinoella@users.noreply.github.com>
rprospero
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Noella Spitz <101950441+rhinoella@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR performs a significant refactoring on the
CIFImportDialog, turning it from a wizard into a fully-featured single-page dialog. Aside from, IMHO, a better UX, a significant secondary reason was the desire to streamline the underlying CIF generation and move away from doing the full, multi-stage generation every time a parameter was changed.The dialog itself now looks like this, with a toolbox on the left-hand side containing all the tweakable parameters, but the majority of space given over to actually seeing what the generated structure will be:
In other news, we also remove the local
CoreDataobject and just go for local instances of the necessary (temporary) objects. A few bug fixes also along the way. Lovely.Closes #1791.