minor

Author: mli

src/app/hello_world/main.cc

@@ -10,22 +10,22 @@ class Hello : public App {
   void init() {
     model_ = new KVVector<uint64, float>(name()+"_model", name());
     LL << "this is " << myNodeID() << ", a " <<
-        (IamWorker() ? "worker" :
-         (IamServer() ? "server" :
-          (IamScheduler() ? "scheduler" : "idle")))
+        (isWorker() ? "worker" :
+         (isServer() ? "server" :
+          (isScheduler() ? "scheduler" : "idle")))
               << " node with rank " << myRank()
        << ", creates model ["
        << model_->name() << "] in app [" << name() << "]";
 
     // initial the weight at server
-    if (IamServer()) {
+    if (isServer()) {
       model_->key() = SArray<uint64>({0, 1, 2, 3, 4, 5});
       model_->value() = SArray<float>({.0, .1, .2, .3, .4, .5});
     }
   }
 
   void run() {
-    if (IamWorker()) {
+    if (isWorker()) {
       // pull
       if (myRank() == 0) {
         model_->key() = SArray<uint64>({0, 2, 4, 5});

src/system/app.h

@@ -6,8 +6,10 @@ class App : public Customer {
   App(const string& name) : Customer(name) { }
   virtual ~App() { }
 
+  // factory functionn
   static App* create(const std::string& name, const std::string& conf);
 
+  // init() is called after this app has been created at all nodes.
   virtual void init() { }
 
   // run() is executed after all nodes have been executed init()
@@ -16,8 +18,3 @@ class App : public Customer {
 };
 
 } // namespace PS
-
-  // factory function, implemented in src/main.cc
-  // static App* create(const AppConfig& config);
-  // // TODO rename to app_conf_
-  // AppConfig app_cf_;

src/system/customer.h

@@ -36,16 +36,16 @@ class Customer {
   // query about my node
   NodeID myNodeID() { return exec_.myNode().id(); }
   int myRank() { return exec_.myNode().rank(); }
-  bool IamWorker() { return exec_.myNode().role() == Node::WORKER; }
-  bool IamServer() { return exec_.myNode().role() == Node::SERVER; }
-  bool IamScheduler() { return exec_.myNode().role() == Node::SCHEDULER; }
+  bool isWorker() { return exec_.myNode().role() == Node::WORKER; }
+  bool isServer() { return exec_.myNode().role() == Node::SERVER; }
+  bool isScheduler() { return exec_.myNode().role() == Node::SCHEDULER; }
 
-  // the unqiue scheduler id
+  // the unique scheduler id
   NodeID schedulerID() { return sys_.scheduler().id(); }
-  // return the executor
-  Executor& exec() { return exec_; }
   // return the remote_note by its name
   RNodePtr port(const NodeID& k) { return exec_.rnode(k); }
+  // return the executor
+  Executor& exec() { return exec_; }
 
  protected:
   string name_;