[ROCM/CodeGen] added initial math functions support to rocm#553
Closed
aditya4d wants to merge 1 commit intoapache:masterfrom
aditya4d:rocm-intrin
Closed
[ROCM/CodeGen] added initial math functions support to rocm#553aditya4d wants to merge 1 commit intoapache:masterfrom aditya4d:rocm-intrin
aditya4d wants to merge 1 commit intoapache:masterfrom
aditya4d:rocm-intrin
Conversation
tqchen
requested changes
Oct 14, 2017
|
|
||
| // num_signature means number of arguments used to query signature | ||
| template<unsigned id, int num_signature> | ||
| inline void DispatchLLVMPureIntrin(const TVMArgs& targs, TVMRetValue* rv) { |
Member
There was a problem hiding this comment.
create a new file intrin_rule_llvm.h and move the two template functions into there so it is shared with intrin_rule_llvm.cc
| call->type, "llvm_intrin", cargs, Call::Intrinsic); | ||
| } | ||
|
|
||
| TVM_REGISTER_GLOBAL("tvm.intrin.rule.llvm.rocm.prefetch") |
Member
There was a problem hiding this comment.
actually we can delete this line, as prefetch is only intended for cpu for now
| TVM_REGISTER_GLOBAL("tvm.intrin.rule.llvm.rocm.prefetch") | ||
| .set_body(DispatchLLVMIntrin<::llvm::Intrinsic::prefetch, 0>); | ||
|
|
||
| TVM_REGISTER_GLOBAL("tvm.intrin.rule.llvm.rocm.exp") |
Member
There was a problem hiding this comment.
same changes in the following functions
This was referenced Oct 15, 2017
Member
|
this is surpassed by #570 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Able to generate
declare f32 @expf()but should bedeclare f32 @llvm.exp.f32()