Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Implement pause/unpause commands#128

Merged
vdemeester merged 1 commit into
docker-archive-public:masterfrom
vdemeester:implement-pause-unpause
Jan 9, 2016
Merged

Implement pause/unpause commands#128
vdemeester merged 1 commit into
docker-archive-public:masterfrom
vdemeester:implement-pause-unpause

Conversation

@vdemeester
Copy link
Copy Markdown
Contributor

Implementing pause and unpause commands from docker-compose. Part of #124 🐙.

$ libcompose-cli ps
WARN[0000] Note: This is an experimental alternate implementation of the Compose CLI (https://github.com/docker/compose) 
Name                             Command  State         Ports
multiple-composefiles_another_1  top      Up 3 seconds  
multiple-composefiles_simple_1   top      Up 3 seconds 

$ libcompose-cli pause
$ libcompose-cli ps
WARN[0000] Note: This is an experimental alternate implementation of the Compose CLI (https://github.com/docker/compose) 
Name                             Command  State                   Ports
multiple-composefiles_simple_1   top      Up 49 seconds (Paused)  
multiple-composefiles_another_1  top      Up 49 seconds (Paused) 

$ libcompose-cli unpause
$ libcompose-cli ps
WARN[0000] Note: This is an experimental alternate implementation of the Compose CLI (https://github.com/docker/compose) 
Name                             Command  State              Ports
multiple-composefiles_another_1  top      Up About a minute  
multiple-composefiles_simple_1   top      Up About a minute 

Just like for docker-compose, issuing multiple times pause or trying to un-pause a non-paused container won't fail, it just won't do anything. Some integration tests reflect that.

🐸

Signed-off-by: Vincent Demeester vincent@sbr.pm

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented, this is to make sure we won't fail in TearDown because of a paused container… So we're trying to unpause all of them and move on 😉.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester
Copy link
Copy Markdown
Contributor Author

/ping @dnephin @ibuildthecloud

@dnephin
Copy link
Copy Markdown
Contributor

dnephin commented Jan 9, 2016

LGTM

vdemeester added a commit that referenced this pull request Jan 9, 2016
@vdemeester vdemeester merged commit 8dc9ff3 into docker-archive-public:master Jan 9, 2016
@vdemeester vdemeester deleted the implement-pause-unpause branch January 9, 2016 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants