Running update.sh fails

[matthiasbeyer]

What I get (replaced shebang with /usr/bin/bash -x):

+ gawk -i inplace -v variant=cli '
                                $1 == "##</autogenerated>##" { ia = 0 }
                                !ia { print }
                                $1 == "##<autogenerated>##" { ia = 1; ab++; ac = 0; if (system("test -f " variant "-Dockerfile-block-" ab) != 0) { ia = 0 } }
                                ia { ac++ }
                                ia && ac == 1 { system("cat " variant "-Dockerfile-block-" ab) }
                        ' 7.2/buster/cli/Dockerfile
Usage: gawk [POSIX or GNU style options] -f progfile [--] file ...
Usage: gawk [POSIX or GNU style options] [--] 'program' file ...
POSIX options:          GNU long options: (standard)
        -f progfile             --file=progfile
        -F fs                   --field-separator=fs
        -v var=val              --assign=var=val
Short options:          GNU long options: (extensions)
        -b                      --characters-as-bytes
        -c                      --traditional
        -C                      --copyright
        -d[file]                --dump-variables[=file]
        -e 'program-text'       --source='program-text'
        -E file                 --exec=file
        -g                      --gen-pot
        -h                      --help
        -L [fatal]              --lint[=fatal]
        -n                      --non-decimal-data
        -N                      --use-lc-numeric
        -O                      --optimize
        -p[file]                --profile[=file]
        -P                      --posix
        -r                      --re-interval
        -S                      --sandbox
        -t                      --lint-old
        -V                      --version

To report bugs, see node `Bugs' in `gawk.info', which is
section `Reporting Problems and Bugs' in the printed version.

gawk is a pattern scanning and processing language.
By default it reads standard input and writes standard output.

Examples:
        gawk '{ sum += $1 }; END { print sum }' file
        gawk -F: '{ print $1 }' /etc/passwd

[wglambert]

Your gawk options are incomplete

$ gawk -V
GNU Awk 5.0.1, API: 2.0
Copyright (C) 1989, 1991-2019 Free Software Foundation.
[. . .]

$ gawk
Usage: gawk [POSIX or GNU style options] -f progfile [--] file ...
Usage: gawk [POSIX or GNU style options] [--] 'program' file ...
POSIX options:          GNU long options: (standard)
        -f progfile             --file=progfile
        -F fs                   --field-separator=fs
        -v var=val              --assign=var=val
Short options:          GNU long options: (extensions)
        -b                      --characters-as-bytes
        -c                      --traditional
        -C                      --copyright
        -d[file]                --dump-variables[=file]
        -D[file]                --debug[=file]
        -e 'program-text'       --source='program-text'
        -E file                 --exec=file
        -g                      --gen-pot
        -h                      --help
        -i includefile          --include=includefile
        -l library              --load=library
        -L[fatal|invalid|no-ext]        --lint[=fatal|invalid|no-ext]
        -M                      --bignum
        -N                      --use-lc-numeric
        -n                      --non-decimal-data
        -o[file]                --pretty-print[=file]
        -O                      --optimize
        -p[file]                --profile[=file]
        -P                      --posix
        -r                      --re-interval
        -s                      --no-optimize
        -S                      --sandbox
        -t                      --lint-old
        -V                      --version
[. . .]

[tianon]

Doh! I guess we should consider not using "inplace" gawk. Out of curiosity, what is it you're trying to accomplish?

[matthiasbeyer]

Out of curiosity, what is it you're trying to accomplish?

I just tried to run the update.sh script, nothing more. Just out of curiousity.

[tianon]

Can you try applying the following patch and see if it completes successfully for you?

diff --git a/update.sh b/update.sh
index 51d765f..9bf130b 100755
--- a/update.sh
+++ b/update.sh
@@ -130,13 +130,14 @@ for version in "${versions[@]}"; do
 			{ generated_warning; cat "$baseDockerfile"; } > "$version/$suite/$variant/Dockerfile"
 
 			echo "Generating $version/$suite/$variant/Dockerfile from $baseDockerfile + $variant-Dockerfile-block-*"
-			gawk -i inplace -v variant="$variant" '
+			gawk -v variant="$variant" '
 				$1 == "##</autogenerated>##" { ia = 0 }
 				!ia { print }
 				$1 == "##<autogenerated>##" { ia = 1; ab++; ac = 0; if (system("test -f " variant "-Dockerfile-block-" ab) != 0) { ia = 0 } }
 				ia { ac++ }
 				ia && ac == 1 { system("cat " variant "-Dockerfile-block-" ab) }
-			' "$version/$suite/$variant/Dockerfile"
+			' "$version/$suite/$variant/Dockerfile" > "$version/$suite/$variant/Dockerfile.new"
+			mv "$version/$suite/$variant/Dockerfile.new" "$version/$suite/$variant/Dockerfile"
 
 			cp -a \
 				docker-php-entrypoint \

[tianon]

This script has changed quite a bit in the meantime (#1052). 😅

Going to close this one. 👍