build: fix build details link in experimental mode#2722
Conversation
crazy-max
force-pushed
the
test-details-link-exp
branch
3 times, most recently
from
052caaa to
a51e219
Compare
crazy-max
changed the title
|
|
||
| message Build { | ||
| string Ref = 1; | ||
| string BuildRef = 2; |
There was a problem hiding this comment.
seems to handle the attached session when monitoring:
Line 466 in d353f5f
will be "local" for local builds:
buildx/controller/local/controller.go
Line 24 in d353f5f
There was a problem hiding this comment.
Can we rename this "kind" or "type" then?
There was a problem hiding this comment.
Looking a bit more at it, for local builds with controller it always set local but for remote it sets a random id that lives across the controller session:
buildx/controller/remote/client.go
Line 120 in 746eadd
So ref is still good but confusing as this is not a build ref. It's even more confusing as we already have BuildOptions.Ref in
buildx/controller/pb/controller.proto
Line 80 in 746eadd
I renamed it to sessionID.
crazy-max
force-pushed
the
test-details-link-exp
branch
from
a51e219 to
52cddf9
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
test-details-link-exp
branch
from
52cddf9 to
eb15c66
Compare
2 participants
fixes #2382
Temp workaround while we are working on cleaning up the controller logic.