Volume API support#764
Merged
Merged
Conversation
shin-
force-pushed
the
744-volume-api-support
branch
from
fea28b4 to
5eb7acc
Compare
Contributor
There was a problem hiding this comment.
This check is rather verbose (and needs to be repeated in a few places). You can actually do something like this to re-use the mark (https://pytest.org/latest/skipping.html#skipif):
def requires_api_version(version):
return pytest.mark.skipif(
docker.utils.compare_version(
version,
docker.constants.DEFAULT_DOCKER_API_VERSION
) < 0,
reason="API version too low"
)
@requires_api_version('1.21')
def test...
shin-
force-pushed
the
744-volume-api-support
branch
from
429af7b to
1952e12
Compare
Remove not exists file in MANIFEST.in
Signed-off-by: Joffrey F <joffrey@docker.com>
shin-
force-pushed
the
744-volume-api-support
branch
from
bb3f332 to
0d39634
Compare
Contributor
Author
|
Included a fix for #769 as well. |
Contributor
There was a problem hiding this comment.
This new decorator is great!
shin-
force-pushed
the
744-volume-api-support
branch
from
9355e2f to
c7cbfb6
Compare
Contributor
|
LGTM (once janky is done and happy) I think the docs for filter format could be improved (currently undefined format), but we can do that as a followup |
…aware Added mock API routes for volumes API Add unit tests and integration tests for volume API Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
Add simpler version comparison functions Add decorator to enforce minimum version in API methods Fix utils imports Add minimum_version decorators on API methods that needed it GroupAdd test requires API version >= 1.20 Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #744