Support for cpu_quota and cpu_period#770
Merged
Merged
Conversation
9d40039 to
6cf7758
Compare
Contributor
There was a problem hiding this comment.
Minor thing, but this style of conditional makes me do a double-take - plus we're immediately doing another check in the second branch. I think a single outer check and two inner checks would be more normal.
Also, could we use version_lt? I find it much easier to read.
if cpu_quota:
if not isinstance(cpu_quota, int):
raise TypeError(...)
if version_lt(version, '1.19'):
raise errors.InvalidVersion(...)
host_config['CpuQuota'] = cpu_quotaSame for the cpu_period conditional.
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
6cf7758 to
3c5185c
Compare
Contributor
Author
|
Should be good now. |
Contributor
|
LGTM |
aanand
added a commit
that referenced
this pull request
Sep 25, 2015
Support for cpu_quota and cpu_period
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #766