Skip to content

builder: Fix setting command with custom shell#32236

Merged
thaJeztah merged 1 commit intomoby:masterfrom
tonistiigi:fix-cmd-shell
Mar 31, 2017
Merged

builder: Fix setting command with custom shell#32236
thaJeztah merged 1 commit intomoby:masterfrom
tonistiigi:fix-cmd-shell

Conversation

@tonistiigi
Copy link
Member

@tonistiigi tonistiigi commented Mar 30, 2017

getShell returned a static array that is appended multiple times. Second append overrides the values for the previous one.

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot derive Dockerfile "FROM gitlab/gitlab-ce" with new CMD - leads to broken /bin/sh -c #(nop) command instead

4 participants