Misc tweaks (#13)

* - More docs in the `coconut-crypto`, especially for modules
- Make `helpers` private in `coconut-crypto`, and move `OwnedPairs` and `Pairs` to `dock_crypto_utils` along with macros.
- Make `SeqValidator` implementations more generic (these changes are fully backward-compatible though)

* Minor improvements

Author: olegnn

bbs_plus/Cargo.toml

@@ -20,7 +20,7 @@ digest.workspace = true
 rayon = {workspace = true, optional = true}
 itertools = "0.10.5"
 schnorr_pok = { version = "0.10.0", default-features = false, path = "../schnorr_pok" }
-dock_crypto_utils = { version = "0.10.0", default-features = false, path = "../utils" }
+dock_crypto_utils = { version = "0.11.0", default-features = false, path = "../utils" }
 serde.workspace = true
 serde_with.workspace = true
 zeroize.workspace = true

benches/Cargo.toml

@@ -18,7 +18,7 @@ serde.workspace = true
 serde_with.workspace = true
 blake2 = { version = "0.10", default-features = false }
 itertools = "0.10.5"
-coconut-crypto = { version = "0.1.0", default-features = false, path = "../coconut" }
+coconut-crypto = { version = "0.2.0", default-features = false, path = "../coconut" }
 dock_crypto_utils = { default-features = false, path = "../utils" }
 zeroize.workspace = true
 

coconut/Cargo.toml

@@ -1,11 +1,11 @@
 [package]
 name = "coconut-crypto"
-version = "0.1.0"
+version = "0.2.0"
 edition.workspace = true
 authors.workspace = true
 license.workspace = true
 repository.workspace = true
-description = "Threshold anonymous credentials based on the paper [Security Analysis of Coconut, an Attribute-Based Credential Scheme with Threshold Issuance](https://eprint.iacr.org/2022/011)"
+description = "Threshold anonymous credentials based on the paper https://eprint.iacr.org/2022/011"
 
 [lib]
 path = "src/lib.rs"
@@ -22,7 +22,7 @@ itertools = "0.10.5"
 zeroize.workspace = true
 serde_with.workspace = true
 rayon = { workspace = true, optional = true }
-utils = { package = "dock_crypto_utils", version = "0.10.0", default-features = false, path = "../utils" }
+utils = { package = "dock_crypto_utils", version = "0.11.0", default-features = false, path = "../utils" }
 schnorr_pok = { version = "0.10.0", default-features = false, path = "../schnorr_pok" }
 secret_sharing_and_dkg = { version = "0.3.0", default-features = false, path = "../secret_sharing_and_dkg" }
 

coconut/src/helpers/mod.rs

@@ -1,3 +1,5 @@
+//! Miscellaneous helpers and re-exports from `dock_crypto_utils`.
+
 use alloc::{format, string::String, vec::Vec};
 
 use ark_ff::PrimeField;
@@ -9,20 +11,18 @@ use ark_std::{cfg_into_iter, cfg_iter};
 
 use schnorr_pok::error::SchnorrError;
 
-pub mod owned_pairs;
-pub mod pairs;
 pub mod with_schnorr_and_blindings;
 pub mod with_schnorr_response;
 
 pub use iter::*;
-pub use owned_pairs::*;
-pub use pairs::*;
 pub use try_iter::*;
 pub use utils::{
     aliases::*,
     extend_some::*,
     iter::{self, *},
     misc::*,
+    owned_pairs::*,
+    pairs::*,
     try_iter::{self, *},
 };
 pub use with_schnorr_and_blindings::*;

coconut/src/lib.rs

@@ -1,9 +1,10 @@
+//! Threshold anonymous credentials based on the paper [Security Analysis of Coconut, an Attribute-Based Credential Scheme with Threshold Issuance](https://eprint.iacr.org/2022/011).
+
 #![cfg_attr(not(feature = "std"), no_std)]
 
 extern crate alloc;
 
-pub mod helpers;
-pub mod macros;
+mod helpers;
 pub mod proof;
 pub mod setup;
 pub mod signature;
@@ -12,4 +13,5 @@ pub mod signature;
 mod tests;
 
 pub use proof::*;
+pub use setup::{keygen, PublicKey, SecretKey};
 pub use signature::*;

coconut/src/macros.rs

@@ -15,11 +15,11 @@ use utils::join;
 use super::UnpackedBlindedMessages;
 use crate::{
     helpers::{schnorr_error, DoubleEndedExactSizeIterator, WithSchnorrAndBlindings},
-    pairs,
     setup::SignatureParams,
     signature::message_commitment::MessageCommitmentRandomness,
     CommitMessage,
 };
+use utils::pairs;
 
 pub mod error;
 pub mod multi_message_commitment;

coconut/src/proof/messages_pok/mod.rs

@@ -19,7 +19,15 @@ use crate::{
 /// `g * o + \sum_{i}(h_{i} * m_{i})`
 #[serde_as]
 #[derive(
-    Clone, Debug, PartialEq, Eq, CanonicalSerialize, CanonicalDeserialize, Serialize, Deserialize,
+    Clone,
+    Copy,
+    Debug,
+    PartialEq,
+    Eq,
+    CanonicalSerialize,
+    CanonicalDeserialize,
+    Serialize,
+    Deserialize,
 )]
 pub struct MultiMessageCommitment<E: Pairing>(#[serde_as(as = "ArkObjectBytes")] E::G1Affine);
 utils::impl_deref! { MultiMessageCommitment<E: Pairing>(E::G1Affine) }

coconut/src/proof/messages_pok/multi_message_commitment.rs

@@ -3,10 +3,8 @@ use alloc::vec::Vec;
 use ark_ec::pairing::Pairing;
 use ark_std::rand::RngCore;
 
-use crate::{
-    helpers::{n_rand, rand, OwnedPairs},
-    owned_pairs,
-};
+use crate::helpers::{n_rand, rand, OwnedPairs};
+use utils::owned_pairs;
 
 /// Witnesses for `MessagesPoK`.
 #[derive(Clone, Debug, PartialEq, Eq)]

coconut/src/proof/messages_pok/witnesses.rs

@@ -1,4 +1,5 @@
 //! Proofs of knowledge for the signature and messages.
+
 use alloc::vec::Vec;
 
 pub mod messages_pok;