Add sandbox agnostic receipt verification#1228
Merged
hyochan merged 1 commit intohyochan:masterfrom Jan 26, 2021
Merged
Conversation
Owner
|
@iaphub Could you kindly review this? Looks like this is somehow related to what you are working on. |
hyochan
approved these changes
Jan 26, 2021
Owner
hyochan
left a comment
There was a problem hiding this comment.
I've just gone through this and this is what Apple wanted. Thanks for your contribution 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per Apple receipt verification best practices:
In case if
isTestparameter isundefinedor defined asnull(basically means that developer prefers to perform environment agnostic check:For the cases when
isTestparameter is explicitly defined astrueorfalse- run the old logic