Port connection pool tests from devdiv#1155
Merged
Merged
Conversation
added 2 commits
July 7, 2021 16:30
cheenamalhotra
added
the
Area\Tests
added 6 commits
July 8, 2021 11:49
Member
cheenamalhotra
left a comment
cheenamalhotra
left a comment
There was a problem hiding this comment.
Just some suggestions to use using to ensure resources are disposed and cleaned up by GC.
Co-authored-by: Cheena Malhotra <v-chmalh@microsoft.com>
…oolTest/ConnectionPoolTest.cs Co-authored-by: Cheena Malhotra <v-chmalh@microsoft.com>
Contributor
DavoudEshtehari
left a comment
DavoudEshtehari
left a comment
There was a problem hiding this comment.
NIT: I'd rather manage a large block of code in a separate file instead of using #if-#endif preprocessor directives.
added 2 commits
August 6, 2021 13:58
Contributor
Author
Created two debug and transaction pool files. |
JRahnama
reviewed
Aug 9, 2021
Member
|
/azp run CI-Win10-SQL19W-TR CI-Win10-SQL19W |
|
No pipelines are associated with this pull request. |
Member
cheenamalhotra
approved these changes
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.