From 14829f0710818e4963818a515f9ed23a6e460ef4 Mon Sep 17 00:00:00 2001 From: Javad Rahnama Date: Fri, 31 Mar 2023 13:41:06 -0700 Subject: [PATCH 1/5] Adding support for net 7.0 Since net8.0 is in preview, we have added support for net7.0 to be able to have access to some of new APIs.When Net8 is released net7.0 will be replaced with net8.0. --- .../ref/Microsoft.Data.SqlClient.csproj | 2 +- .../netcore/src/.editorconfig | 3 ++ ...oft.Data.SqlClient.PerformanceTests.csproj | 2 +- ...crosoft.Data.SqlClient.ExtUtilities.csproj | 2 +- .../Microsoft.DotNet.GenAPI.csproj | 2 +- tools/specs/Microsoft.Data.SqlClient.nuspec | 33 +++++++++++++++++++ ...waysEncrypted.AzureKeyVaultProvider.nuspec | 17 ++++++++++ tools/targets/NotSupported.targets | 2 +- 8 files changed, 58 insertions(+), 5 deletions(-) diff --git a/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj index 41e1263abc..96308eae65 100644 --- a/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj @@ -1,7 +1,7 @@  false - net6.0;netstandard2.0;netstandard2.1 + net7.0;net6.0;netstandard2.0;netstandard2.1 netstandard2.1 $(ObjFolder)$(Configuration)\$(AssemblyName)\ref\ $(BinFolder)$(Configuration)\$(AssemblyName)\ref\ diff --git a/src/Microsoft.Data.SqlClient/netcore/src/.editorconfig b/src/Microsoft.Data.SqlClient/netcore/src/.editorconfig index ecc808aa66..d31a6e9603 100644 --- a/src/Microsoft.Data.SqlClient/netcore/src/.editorconfig +++ b/src/Microsoft.Data.SqlClient/netcore/src/.editorconfig @@ -10,3 +10,6 @@ csharp_style_implicit_object_creation_when_type_is_apparent = false # IDE0063: Use simple 'using' statement csharp_prefer_simple_using_statement = false + +# SYSLIB0039: Type or member is obsolete +dotnet_diagnostic.SYSLIB0039.severity = none diff --git a/src/Microsoft.Data.SqlClient/tests/PerformanceTests/Microsoft.Data.SqlClient.PerformanceTests.csproj b/src/Microsoft.Data.SqlClient/tests/PerformanceTests/Microsoft.Data.SqlClient.PerformanceTests.csproj index 192b6f3a17..6dbd13b8d6 100644 --- a/src/Microsoft.Data.SqlClient/tests/PerformanceTests/Microsoft.Data.SqlClient.PerformanceTests.csproj +++ b/src/Microsoft.Data.SqlClient/tests/PerformanceTests/Microsoft.Data.SqlClient.PerformanceTests.csproj @@ -2,7 +2,7 @@ Exe PerformanceTests - net6.0 + net6.0;net7.0 false Debug;Release; $(ObjFolder)$(Configuration).$(Platform).$(AssemblyName) diff --git a/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj b/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj index ab120d549f..78751bd6d1 100644 --- a/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj +++ b/src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.ExtUtilities/Microsoft.Data.SqlClient.ExtUtilities.csproj @@ -1,7 +1,7 @@  Exe - net6.0 + net6.0;net7.0 Microsoft.Data.SqlClient.ExtUtilities.Runner diff --git a/tools/GenAPI/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj b/tools/GenAPI/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj index 8bfcd7ad1e..974e70c687 100644 --- a/tools/GenAPI/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj +++ b/tools/GenAPI/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj @@ -2,7 +2,7 @@ Exe - net472;net6.0 + net472;net6.0;net7.0 true MSBuildSdk false diff --git a/tools/specs/Microsoft.Data.SqlClient.nuspec b/tools/specs/Microsoft.Data.SqlClient.nuspec index aded7d902a..304837ab29 100644 --- a/tools/specs/Microsoft.Data.SqlClient.nuspec +++ b/tools/specs/Microsoft.Data.SqlClient.nuspec @@ -38,6 +38,21 @@ When using NuGet 3.x this package requires at least version 3.4. + + + + + + + + + + + + + + + @@ -96,6 +111,11 @@ When using NuGet 3.x this package requires at least version 3.4. + + + + + @@ -123,6 +143,10 @@ When using NuGet 3.x this package requires at least version 3.4. + + + + @@ -154,6 +178,10 @@ When using NuGet 3.x this package requires at least version 3.4. + + + + @@ -172,6 +200,11 @@ When using NuGet 3.x this package requires at least version 3.4. + + + + + diff --git a/tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec b/tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec index e243d20e26..dd0bfdbcf8 100644 --- a/tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec +++ b/tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec @@ -30,6 +30,13 @@ Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyStoreProvider.SqlColumnEncrypti + + + + + + + @@ -62,6 +69,16 @@ Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyStoreProvider.SqlColumnEncrypti + + + + + + + + + + diff --git a/tools/targets/NotSupported.targets b/tools/targets/NotSupported.targets index 3be0460dd1..890c4ae048 100644 --- a/tools/targets/NotSupported.targets +++ b/tools/targets/NotSupported.targets @@ -42,7 +42,7 @@ $(GenAPIArgs) -o:"$(NotSupportedSourceFile)" $(GenAPIArgs) -t:"$(GeneratePlatformNotSupportedAssemblyMessage)" $(GenAPIArgs) -global - "$(DotNetCmd) $(ToolsArtifactsDir)net6.0\Microsoft.DotNet.GenAPI.dll" + "$(DotNetCmd) $(ToolsArtifactsDir)$(TargetFramework)\Microsoft.DotNet.GenAPI.dll" "$(ToolsArtifactsDir)net472\Microsoft.DotNet.GenAPI.exe" From 3bb7df59f9cd73318a2dd0512403528750cd5415 Mon Sep 17 00:00:00 2001 From: Javad Rahnama Date: Mon, 24 Apr 2023 16:12:43 -0700 Subject: [PATCH 2/5] commit --- .../netcore/src/Microsoft.Data.SqlClient.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj index 0311969820..be1eb19b17 100644 --- a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj @@ -1,7 +1,7 @@  Microsoft.Data.SqlClient - net6.0;netstandard2.0;netstandard2.1 + net7.0;net6.0;netstandard2.0;netstandard2.1 netstandard2.1 Microsoft.Data.SqlClient is not supported on this platform. $(OS) From f7c02da0d4f79847a111fd946531b129a52b2d37 Mon Sep 17 00:00:00 2001 From: Javad Rahnama Date: Mon, 24 Apr 2023 21:38:31 -0700 Subject: [PATCH 3/5] commit --- src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props b/src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props index 762c5f9ed8..2cce61f7ac 100644 --- a/src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props +++ b/src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props @@ -36,7 +36,7 @@ netstandard2.0;netstandard2.1 - net6.0 + net6.0;net7.0 net462 From 258226c158f08123b529f23f27493549f50f3361 Mon Sep 17 00:00:00 2001 From: Javad Date: Mon, 1 May 2023 13:50:26 -0700 Subject: [PATCH 4/5] Apply suggestions from code review Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com> Co-authored-by: David Engel --- tools/specs/Microsoft.Data.SqlClient.nuspec | 2 +- ....Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/specs/Microsoft.Data.SqlClient.nuspec b/tools/specs/Microsoft.Data.SqlClient.nuspec index 03b5bf3d5f..7e5267983f 100644 --- a/tools/specs/Microsoft.Data.SqlClient.nuspec +++ b/tools/specs/Microsoft.Data.SqlClient.nuspec @@ -113,7 +113,7 @@ When using NuGet 3.x this package requires at least version 3.4. - + diff --git a/tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec b/tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec index dd0bfdbcf8..5db2b63101 100644 --- a/tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec +++ b/tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec @@ -31,7 +31,7 @@ Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyStoreProvider.SqlColumnEncrypti - + From d68aca5fb72d4b33bb8b8fd99226a30cf05d964c Mon Sep 17 00:00:00 2001 From: Javad Date: Tue, 2 May 2023 13:43:20 -0700 Subject: [PATCH 5/5] Apply suggestions from code review Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com> --- src/Microsoft.Data.SqlClient/netcore/src/.editorconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.Data.SqlClient/netcore/src/.editorconfig b/src/Microsoft.Data.SqlClient/netcore/src/.editorconfig index d31a6e9603..6225d05c63 100644 --- a/src/Microsoft.Data.SqlClient/netcore/src/.editorconfig +++ b/src/Microsoft.Data.SqlClient/netcore/src/.editorconfig @@ -12,4 +12,4 @@ csharp_style_implicit_object_creation_when_type_is_apparent = false csharp_prefer_simple_using_statement = false # SYSLIB0039: Type or member is obsolete -dotnet_diagnostic.SYSLIB0039.severity = none +dotnet_diagnostic.SYSLIB0039.severity = suggestion