From 633153a67b1def73793c4c6c5c43ad85430be619 Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Tue, 2 Mar 2021 10:52:37 -0800 Subject: [PATCH 1/2] Fix | Fix trace string bug --- .../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs | 1 - .../netfx/src/Microsoft/Data/SqlClient/TdsParser.cs | 1 - 2 files changed, 2 deletions(-) diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs index 788aaf3511..32c837003a 100644 --- a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs +++ b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs @@ -12776,7 +12776,6 @@ internal string TraceString() _defaultCodePage, _defaultLCID, TraceObjectClass(_defaultEncoding), - "", _encryptionOption, null == _currentTransaction ? "(null)" : _currentTransaction.TraceString(), null == _pendingTransaction ? "(null)" : _pendingTransaction.TraceString(), diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs index 92368b17bb..787f06d175 100644 --- a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs +++ b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs @@ -13707,7 +13707,6 @@ internal string TraceString() _defaultCodePage, _defaultLCID, TraceObjectClass(_defaultEncoding), - "", _encryptionOption, null == _currentTransaction ? "(null)" : _currentTransaction.TraceString(), null == _pendingTransaction ? "(null)" : _pendingTransaction.TraceString(), From db5404caf4ca48d4472d53264072125102aedba7 Mon Sep 17 00:00:00 2001 From: Cheena Malhotra Date: Tue, 2 Mar 2021 11:44:11 -0800 Subject: [PATCH 2/2] Fix + review feedback --- .../src/Microsoft/Data/SqlClient/TdsParser.cs | 4 +- .../src/Microsoft/Data/SqlClient/TdsParser.cs | 44 +++++++++---------- 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs index 32c837003a..5e2bff208c 100644 --- a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs +++ b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs @@ -12767,8 +12767,8 @@ internal string TraceString() { return string.Format(/*IFormatProvider*/ null, StateTraceFormatString, - null == _physicalStateObj ? bool.TrueString : bool.FalseString, - null == _pMarsPhysicalConObj ? bool.TrueString : bool.FalseString, + null == _physicalStateObj ? "(null)" : _physicalStateObj.ObjectID.ToString((IFormatProvider)null), + null == _pMarsPhysicalConObj ? "(null)" : _pMarsPhysicalConObj.ObjectID.ToString((IFormatProvider)null), _state, _server, _fResetConnection ? bool.TrueString : bool.FalseString, diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs index 787f06d175..2a5f4ca1c9 100644 --- a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs +++ b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs @@ -13673,33 +13673,33 @@ internal ulong PlpBytesTotalLength(TdsParserStateObject stateObj) + " _defaultCodePage = {6}\n\t" + " _defaultLCID = {7}\n\t" + " _defaultEncoding = {8}\n\t" - + " _encryptionOption = {10}\n\t" - + " _currentTransaction = {11}\n\t" - + " _pendingTransaction = {12}\n\t" - + " _retainedTransactionId = {13}\n\t" - + " _nonTransactedOpenResultCount = {14}\n\t" - + " _connHandler = {15}\n\t" - + " _fMARS = {16}\n\t" - + " _sessionPool = {17}\n\t" - + " _isShiloh = {18}\n\t" - + " _isShilohSP1 = {19}\n\t" - + " _isYukon = {20}\n\t" - + " _sniSpnBuffer = {21}\n\t" - + " _errors = {22}\n\t" - + " _warnings = {23}\n\t" - + " _attentionErrors = {24}\n\t" - + " _attentionWarnings = {25}\n\t" - + " _statistics = {26}\n\t" - + " _statisticsIsInTransaction = {27}\n\t" - + " _fPreserveTransaction = {28}" - + " _fParallel = {29}" + + " _encryptionOption = {9}\n\t" + + " _currentTransaction = {10}\n\t" + + " _pendingTransaction = {11}\n\t" + + " _retainedTransactionId = {12}\n\t" + + " _nonTransactedOpenResultCount = {13}\n\t" + + " _connHandler = {14}\n\t" + + " _fMARS = {15}\n\t" + + " _sessionPool = {16}\n\t" + + " _isShiloh = {17}\n\t" + + " _isShilohSP1 = {18}\n\t" + + " _isYukon = {19}\n\t" + + " _sniSpnBuffer = {20}\n\t" + + " _errors = {21}\n\t" + + " _warnings = {22}\n\t" + + " _attentionErrors = {23}\n\t" + + " _attentionWarnings = {24}\n\t" + + " _statistics = {25}\n\t" + + " _statisticsIsInTransaction = {26}\n\t" + + " _fPreserveTransaction = {27}" + + " _fParallel = {28}" ; internal string TraceString() { return string.Format(/*IFormatProvider*/ null, StateTraceFormatString, - null == _physicalStateObj ? bool.TrueString : bool.FalseString, - null == _pMarsPhysicalConObj ? bool.TrueString : bool.FalseString, + null == _physicalStateObj ? "(null)" : _physicalStateObj.ObjectID.ToString((IFormatProvider)null), + null == _pMarsPhysicalConObj ? "(null)" : _pMarsPhysicalConObj.ObjectID.ToString((IFormatProvider)null), _state, _server, _fResetConnection ? bool.TrueString : bool.FalseString,