Simplify TryGetJniNameForType to use IJniNameProviderAttribute

Both RegisterAttribute and JniTypeSignatureAttribute implement
IJniNameProviderAttribute, so a single GetCustomAttributes check
covers both. Made the method internal+static so
TrimmableTypeMapTypeManager.GetSimpleReferences can reuse it
instead of duplicating the attribute lookup.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: simonrozsival

src/Mono.Android/Microsoft.Android.Runtime/TrimmableTypeMap.cs

@@ -96,26 +96,14 @@ internal bool TryGetType (string jniSimpleReference, [NotNullWhen (true)] out Ty
 	}
 
 	/// <summary>
-	/// Resolves a managed type's JNI name from its [Register] or [JniTypeSignature] attributes.
+	/// Resolves a managed type's JNI name from its <see cref="IJniNameProviderAttribute"/>
+	/// (implemented by both <c>[Register]</c> and <c>[JniTypeSignature]</c>).
 	/// </summary>
-	static bool TryGetJniNameForType (Type type, [NotNullWhen (true)] out string? jniName)
+	internal static bool TryGetJniNameForType (Type type, [NotNullWhen (true)] out string? jniName)
 	{
-		// Check [Register("jniName", ...)] attribute (Mono.Android binding types)
-		foreach (var attr in type.GetCustomAttributesData ()) {
-			if (attr.AttributeType.FullName == "Android.Runtime.RegisterAttribute"
-				&& attr.ConstructorArguments.Count > 0
-				&& attr.ConstructorArguments[0].Value is string name
-				&& name.Length > 0
-				&& !name.Contains ('(')) { // Skip method-level [Register]
-				jniName = name;
-				return true;
-			}
-		}
-
-		// Check [JniTypeSignature("jniName")] attribute (Java.Interop types)
-		var sigAttr = type.GetCustomAttribute<JniTypeSignatureAttribute> (inherit: false);
-		if (sigAttr is not null && !string.IsNullOrEmpty (sigAttr.SimpleReference)) {
-			jniName = sigAttr.SimpleReference;
+		var provider = type.GetCustomAttribute<IJniNameProviderAttribute> (inherit: false);
+		if (provider is not null && !string.IsNullOrEmpty (provider.Name)) {
+			jniName = provider.Name.Replace ('.', '/');
 			return true;
 		}
 

src/Mono.Android/Microsoft.Android.Runtime/TrimmableTypeMapTypeManager.cs

@@ -39,9 +39,8 @@ protected override IEnumerable<string> GetSimpleReferences (Type type)
 			yield return r;
 		}
 
-		var attr = type.GetCustomAttributes (typeof (IJniNameProviderAttribute), inherit: false);
-		if (attr.Length > 0 && attr [0] is IJniNameProviderAttribute jniNameProvider && !string.IsNullOrEmpty (jniNameProvider.Name)) {
-			yield return jniNameProvider.Name.Replace ('.', '/');
+		if (TrimmableTypeMap.TryGetJniNameForType (type, out var jniName)) {
+			yield return jniName;
 		}
 	}