Skip to content

Commit e0d2614

Browse files
[build] Revert BinSkim analyzeTargetGlob customization (#10964)
Revert the `analyzeTargetGlob` customization added in PRs #10940, #10953, and #10961. The custom glob patterns caused more problems than they solved: - `+|bin\Build*\**` — Guardian can't parse `+|` prefix (#10953) - `bin\Build*\**` — breaks the 'Convert NuGet to MSI' job which has no `bin\Build*\` directory (#10961) - `bin\Build*\**;bin\msi-nupkgs\**` — Guardian can't parse semicolons, breaks every job Remove `analyzeTargetGlob` entirely and keep only `scanOutputDirectoryOnly: true`, which is the default configuration that worked before #10940.
1 parent 0f6a01b commit e0d2614

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

build-tools/automation/azure-pipelines.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,6 @@ extends:
6060
enableAllTools: false
6161
binskim:
6262
scanOutputDirectoryOnly: true
63-
# Scan build output and MSI conversion output, but not test assemblies
64-
# under bin/Test* which produce BA2021 false positives.
65-
# Both patterns are needed because the 1ES template applies sdl config
66-
# globally: build/test jobs produce bin\Build*\ output, while the
67-
# "Convert NuGet to MSI" job only produces bin\msi-nupkgs\ output.
68-
analyzeTargetGlob: bin\Build*\**;bin\msi-nupkgs\**
6963
codeql:
7064
compiled:
7165
enabled: false

0 commit comments

Comments
 (0)