Add AspireExport coverage for Aspire.Hosting.Azure.ServiceBus#14665
Merged
sebastienros merged 3 commits intorelease/13.2from Feb 25, 2026
Merged
Add AspireExport coverage for Aspire.Hosting.Azure.ServiceBus#14665sebastienros merged 3 commits intorelease/13.2from
sebastienros merged 3 commits intorelease/13.2from
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14665Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14665" |
76 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR advances the TypeScript (polyglot) AppHost effort for Aspire.Hosting.Azure.ServiceBus by annotating the integration surface with [AspireExport]/[AspireDto] so it can be discovered by ATS capability scanning and used from generated TypeScript SDKs (per #14069).
Changes:
- Adds
[AspireExport]coverage for key Azure Service Bus builder extension methods (and hides non-polyglot-compatible overloads via[AspireExportIgnore]). - Exposes Service Bus queue/topic/subscription resources to polyglot SDKs via
[AspireExport(ExposeProperties = true)]and marks unsupported properties with[AspireExportIgnore]. - Adds DTO annotations for rule/filter types and a new TypeScript ValidationAppHost playground to exercise generated APIs.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusTopicResource.cs | Exports topic resource type; ignores non-polyglot properties. |
| src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusSubscriptionResource.cs | Exports subscription resource type; ignores non-polyglot properties. |
| src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusQueueResource.cs | Exports queue resource type; ignores non-polyglot properties. |
| src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusRule.cs | Marks rule type as DTO for polyglot serialization. |
| src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusCorrelationFilter.cs | Marks correlation filter type as DTO for polyglot serialization. |
| src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusExtensions.cs | Adds [AspireExport] for add/configure APIs; adds string-based role assignment overload for polyglot. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ServiceBus/ValidationAppHost/tsconfig.json | Adds TS config for the validation app host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ServiceBus/ValidationAppHost/package.json | Adds npm scripts/deps for the validation app host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ServiceBus/ValidationAppHost/package-lock.json | Locks npm dependency graph for the validation app host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ServiceBus/ValidationAppHost/apphost.ts | Adds a TS AppHost script intended to validate generated exports. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ServiceBus/ValidationAppHost/apphost.run.json | Adds run profile configuration for the validation app host. |
| playground/polyglot/TypeScript/Aspire.Hosting.Azure.ServiceBus/ValidationAppHost/.aspire/settings.json | Adds Aspire CLI settings for the validation app host. |
Files not reviewed (1)
- playground/polyglot/TypeScript/Aspire.Hosting.Azure.ServiceBus/ValidationAppHost/package-lock.json: Language not supported
src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusExtensions.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusExtensions.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.ServiceBus/AzureServiceBusExtensions.cs
Outdated
Show resolved
Hide resolved
.../polyglot/TypeScript/Aspire.Hosting.Azure.ServiceBus/ValidationAppHost/.aspire/settings.json
Outdated
Show resolved
Hide resolved
playground/polyglot/TypeScript/Aspire.Hosting.Azure.ServiceBus/ValidationAppHost/apphost.ts
Show resolved
Hide resolved
Contributor
🎬 CLI E2E Test RecordingsThe following terminal recordings are available for commit
📹 Recordings uploaded automatically from CI run #22378908208 |
davidfowl
approved these changes
Feb 25, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Mar 10, 2026
* Add AspireExport coverage for Aspire.Hosting.Azure.ServiceBus * Fix codegen issues * Fix other languages tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14069