Enable setting ServerTimeout and KeepAliveInterval in HubConnectionBuilder#46065
Merged
Conversation
…lder for csharp client
ghost
added
the
…s.cs Co-authored-by: Brennan <brecon@microsoft.com>
Co-authored-by: Brennan <brecon@microsoft.com>
Co-authored-by: Brennan <brecon@microsoft.com>
…rExtensions.cs Co-authored-by: Brennan <brecon@microsoft.com>
…ubConnection 2. Added test to HubConnectionBuilderTests
…aspnetcore into hubConnectionBuilder
BrennanConroy
approved these changes
Jan 18, 2023
Co-authored-by: Brennan <brecon@microsoft.com>
Co-authored-by: Brennan <brecon@microsoft.com>
halter73
approved these changes
Jan 18, 2023
Member
halter73
left a comment
halter73
left a comment
There was a problem hiding this comment.
Do we want to do the same thing in HttpHubConnectionBuilder.java? If we do, it doesn't have to be in this PR.
…tervalInMilliseconds in HubConnection ts client
…aspnetcore into hubConnectionBuilder
Member
Author
Yes. It will be in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable setting ServerTimeout and KeepAliveInterval in HubConnectionBuilder
Added withServerTimeout and withKeepAliveInterval in HubConnectionBuilder for ts and csharp clients
Fixes #18840 and partially #44742