Add RequestServices to HttpContext debugging#49212
Merged
Merged
Conversation
JamesNK
requested review from
BrennanConroy,
Tratcher,
captainsafia and
halter73
as code owners
mitchdenny
approved these changes
Jul 5, 2023
Member
mitchdenny
left a comment
mitchdenny
left a comment
There was a problem hiding this comment.
Makes sense to me - but I don't know if we need more than me to say that given its a (albeit small) public API change.
Member
Author
|
It's not public API. It's on the private debug proxy type. |
ghost
added this to the
amcasey
added
area-networking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpContext.RequestServicesshould be included inHttpContextdebug view now that DI's debug display has improved.See dotnet/runtime#88082 for more info.