From 746cfebb4cd9c19f9a7fd7e87c8f3e65c3ee196f Mon Sep 17 00:00:00 2001 From: Andon Andonov Date: Tue, 21 Nov 2017 17:25:46 -0800 Subject: [PATCH 1/3] ILCompiler nuget package support --- buildpipeline/DotNet-CoreRT-Publish.json | 6 +-- dir.props | 2 +- .../Microsoft.DotNet.ILCompiler.builds | 12 ++++++ .../Microsoft.DotNet.ILCompiler.pkgproj | 40 ++++++++----------- .../Microsoft.DotNet.ILCompiler.targets | 7 ++++ pkg/packageIndex.json | 4 ++ pkg/packages.proj | 8 ++-- .../Microsoft.NETCore.Native.targets | 5 ++- 8 files changed, 53 insertions(+), 31 deletions(-) create mode 100644 pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.builds create mode 100644 pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.targets diff --git a/buildpipeline/DotNet-CoreRT-Publish.json b/buildpipeline/DotNet-CoreRT-Publish.json index c0b3486bc16..ed451610e6d 100644 --- a/buildpipeline/DotNet-CoreRT-Publish.json +++ b/buildpipeline/DotNet-CoreRT-Publish.json @@ -94,7 +94,7 @@ "scriptType": "inlineScript", "scriptName": "", "arguments": "", - "inlineScript": "if ($env:Configuration -ne \"Release\") { exit }\n\n& $env:Build_SourcesDirectory\\scripts\\DotNet-Trusted-Publish\\Embed-Index.ps1 `\n $env:Pipeline_SourcesDirectory\\packages\\AzureTransfer\\Windows_NT.x64.$env:Configuration\\Microsoft.TargetingPack.Private.CoreRT\\$env:AzureContainerSymbolPackageGlob `\n $env:Build_StagingDirectory\\IndexedSymbolPackages", + "inlineScript": "if ($env:Configuration -ne \"Release\") { exit }\n\n& $env:Build_SourcesDirectory\\scripts\\DotNet-Trusted-Publish\\Embed-Index.ps1 `\n $env:Pipeline_SourcesDirectory\\packages\\AzureTransfer\\Windows_NT.x64.$env:Configuration\\$env:AzureContainerSymbolPackageGlob `\n $env:Build_StagingDirectory\\IndexedSymbolPackages", "workingFolder": "", "failOnStandardError": "true" } @@ -152,7 +152,7 @@ "scriptType": "inlineScript", "scriptName": "", "arguments": "$(MyGetApiKey)", - "inlineScript": "param($ApiKey)\nif ($env:Configuration -ne \"Release\") { exit }\n& $env:CustomNuGetPath push $env:Pipeline_SourcesDirectory\\packages\\AzureTransfer\\Windows_NT.x64.$env:Configuration\\Microsoft.TargetingPack.Private.CoreRT\\$env:AzureContainerPackageGlob $ApiKey -Source $env:MyGetFeedUrl -Timeout 3600", + "inlineScript": "param($ApiKey)\nif ($env:Configuration -ne \"Release\") { exit }\n& $env:CustomNuGetPath push $env:Pipeline_SourcesDirectory\\packages\\AzureTransfer\\Windows_NT.x64.$env:Configuration\\$env:AzureContainerPackageGlob $ApiKey -Source $env:MyGetFeedUrl -Timeout 3600", "workingFolder": "", "failOnStandardError": "true" } @@ -192,7 +192,7 @@ "scriptType": "inlineScript", "scriptName": "", "arguments": "-gitHubAuthToken $(UpdatePublishedVersions.AuthToken) -root $(Pipeline.SourcesDirectory)", - "inlineScript": "param($gitHubAuthToken, $root)\nif ($env:Configuration -ne \"Release\") { exit }\ncd $root\n. $root\\buildscripts\\UpdatePublishedVersions.ps1 `\n -gitHubUser dotnet-build-bot -gitHubEmail dotnet-build-bot@microsoft.com `\n -gitHubAuthToken $gitHubAuthToken `\n -versionsRepoOwner $env:VersionsRepoOwner -versionsRepo $env:VersionsRepo `\n -versionsRepoPath build-info/dotnet/$env:GitHubRepositoryName/$env:SourceBranch `\n -nupkgPath $root\\packages\\AzureTransfer\\Windows_NT.x64.$env:Configuration\\Microsoft.TargetingPack.Private.CoreRT\\$env:AzureContainerPackageGlob", + "inlineScript": "param($gitHubAuthToken, $root)\nif ($env:Configuration -ne \"Release\") { exit }\ncd $root\n. $root\\buildscripts\\UpdatePublishedVersions.ps1 `\n -gitHubUser dotnet-build-bot -gitHubEmail dotnet-build-bot@microsoft.com `\n -gitHubAuthToken $gitHubAuthToken `\n -versionsRepoOwner $env:VersionsRepoOwner -versionsRepo $env:VersionsRepo `\n -versionsRepoPath build-info/dotnet/$env:GitHubRepositoryName/$env:SourceBranch `\n -nupkgPath $root\\packages\\AzureTransfer\\Windows_NT.x64.$env:Configuration\\$env:AzureContainerPackageGlob", "workingFolder": "", "failOnStandardError": "true" } diff --git a/dir.props b/dir.props index 028d688d044..00fa26eb7a5 100644 --- a/dir.props +++ b/dir.props @@ -135,7 +135,7 @@ $(DotnetCliPath) - $(PackageOutputRoot)$(OSPlatformConfig)/$(MSBuildProjectName)/ + $(PackageOutputRoot)$(OSPlatformConfig)/ $(PackageOutputPath)symbols/ diff --git a/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.builds b/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.builds new file mode 100644 index 00000000000..841203881cb --- /dev/null +++ b/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.builds @@ -0,0 +1,12 @@ + + + + + + Windows_NT + Linux + Mac + + + + diff --git a/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.pkgproj b/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.pkgproj index 03098cb7c56..b1c97b10ec4 100644 --- a/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.pkgproj +++ b/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.pkgproj @@ -1,9 +1,5 @@ - - - - true false @@ -11,27 +7,25 @@ true true + + - - - - - - - - - - 1.0.13-prerelease-00001 - - - 1.2.0-beta-24815-03 - - - 1.2.0 - - - + + build + + + targets + + + tools + + + sdk + + + framework + diff --git a/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.targets b/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.targets new file mode 100644 index 00000000000..37c3569695a --- /dev/null +++ b/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.targets @@ -0,0 +1,7 @@ + + + <_ILCompilerRootDir>$(MSBuildThisFileDirectory)../ + $(_ILCompilerRootDir)targets/ + + + diff --git a/pkg/packageIndex.json b/pkg/packageIndex.json index 1b47ad46889..f1839ab6646 100644 --- a/pkg/packageIndex.json +++ b/pkg/packageIndex.json @@ -4,6 +4,10 @@ "StableVersions": [], "BaselineVersion": "1.0.0", }, + "Microsoft.DotNet.ILCompiler" : { + "StableVersions": [], + "BaselineVersion": "1.0.0", + }, "Microsoft.TargetingPack.Private.CoreRT" : { "StableVersions": [], "BaselineVersion": "1.0.0", diff --git a/pkg/packages.proj b/pkg/packages.proj index 80f05e92fb9..3bb73962be2 100644 --- a/pkg/packages.proj +++ b/pkg/packages.proj @@ -6,11 +6,13 @@ false - - + + AnyOS - + + AnyOS + diff --git a/src/BuildIntegration/Microsoft.NETCore.Native.targets b/src/BuildIntegration/Microsoft.NETCore.Native.targets index 5489fbbc572..906d3cdfd38 100644 --- a/src/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/BuildIntegration/Microsoft.NETCore.Native.targets @@ -23,6 +23,8 @@ See the LICENSE file in the project root for more information. OSX $(OS) + + $([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), Microsoft.DotNet.ILCompiler.nuspec)) @@ -128,7 +130,8 @@ See the LICENSE file in the project root for more information. - + + From 3456f13acf7ced1d17a186d714ae408f2b0ed996 Mon Sep 17 00:00:00 2001 From: Andon Andonov Date: Fri, 1 Dec 2017 16:30:00 -0800 Subject: [PATCH 2/3] Add symbols for native libraries to package and remove OS detection workaround --- .../Microsoft.DotNet.ILCompiler.pkgproj | 18 ++++++++++++++++++ .../Microsoft.NETCore.Native.targets | 8 ++++---- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.pkgproj b/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.pkgproj index b1c97b10ec4..b437e405c86 100644 --- a/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.pkgproj +++ b/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.pkgproj @@ -6,6 +6,7 @@ x64; true true + true @@ -26,6 +27,23 @@ framework + + + + sdk + + + sdk + + + sdk + + + sdk + + + sdk + diff --git a/src/BuildIntegration/Microsoft.NETCore.Native.targets b/src/BuildIntegration/Microsoft.NETCore.Native.targets index 906d3cdfd38..20065cdc8b7 100644 --- a/src/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/BuildIntegration/Microsoft.NETCore.Native.targets @@ -22,9 +22,10 @@ See the LICENSE file in the project root for more information. true OSX + + $(OS) - - $([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), Microsoft.DotNet.ILCompiler.nuspec)) + $(MSBuildThisFileDirectory)/.. @@ -130,8 +131,7 @@ See the LICENSE file in the project root for more information. - - + From cc9eeeeb947c704c57f996854974a6ceab24d75f Mon Sep 17 00:00:00 2001 From: Andon Andonov Date: Mon, 4 Dec 2017 15:35:17 -0800 Subject: [PATCH 3/3] Whitespace --- .../Microsoft.DotNet.ILCompiler.targets | 4 ++-- pkg/packages.proj | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.targets b/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.targets index 37c3569695a..28e6f9aa7c1 100644 --- a/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.targets +++ b/pkg/Microsoft.DotNet.ILCompiler/Microsoft.DotNet.ILCompiler.targets @@ -1,7 +1,7 @@ - <_ILCompilerRootDir>$(MSBuildThisFileDirectory)../ - $(_ILCompilerRootDir)targets/ + <_ILCompilerRootDir>$(MSBuildThisFileDirectory)../ + $(_ILCompilerRootDir)targets/ diff --git a/pkg/packages.proj b/pkg/packages.proj index 3bb73962be2..83764c693b7 100644 --- a/pkg/packages.proj +++ b/pkg/packages.proj @@ -1,20 +1,20 @@ - + $(BinDir)pkg/reports/ false - + AnyOS - - AnyOS + + AnyOS - +