From 68cbe61216c01129b7cc7ea8dd47ca45cc1da3b0 Mon Sep 17 00:00:00 2001 From: Juan Hoyos Date: Tue, 28 Jun 2022 16:04:50 -0700 Subject: [PATCH 1/6] Add help for command flag of dotnet-dump --- src/Tools/dotnet-dump/Program.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tools/dotnet-dump/Program.cs b/src/Tools/dotnet-dump/Program.cs index 45368c7d44..69eabe9b85 100644 --- a/src/Tools/dotnet-dump/Program.cs +++ b/src/Tools/dotnet-dump/Program.cs @@ -108,7 +108,7 @@ private static Argument DumpPath() => private static Option RunCommand() => new Option( aliases: new[] { "-c", "--command" }, - description: "Run the command on start.") + description: "Runs the command on start. Multiple instances of this can be used in a command to chain commands, they will be run in the order they are provided on the commandline.") { Argument = new Argument(name: "command", getDefaultValue: () => Array.Empty()) { Arity = ArgumentArity.ZeroOrMore } }; From b4fcc4c15d6b68411b512341c55596f665cd47ab Mon Sep 17 00:00:00 2001 From: Juan Hoyos Date: Tue, 28 Jun 2022 16:08:31 -0700 Subject: [PATCH 2/6] Update Program.cs --- src/Tools/dotnet-dump/Program.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tools/dotnet-dump/Program.cs b/src/Tools/dotnet-dump/Program.cs index 69eabe9b85..408f4b3287 100644 --- a/src/Tools/dotnet-dump/Program.cs +++ b/src/Tools/dotnet-dump/Program.cs @@ -108,7 +108,7 @@ private static Argument DumpPath() => private static Option RunCommand() => new Option( aliases: new[] { "-c", "--command" }, - description: "Runs the command on start. Multiple instances of this can be used in a command to chain commands, they will be run in the order they are provided on the commandline.") + description: "Runs the command on start. Multiple instances of this parameter can be used in an invocation to chain commands. They will get run in the order that they are provided on the commandline.") { Argument = new Argument(name: "command", getDefaultValue: () => Array.Empty()) { Arity = ArgumentArity.ZeroOrMore } }; From ef60af09a319047cd01761310f5eba79eac9c00a Mon Sep 17 00:00:00 2001 From: Juan Hoyos Date: Tue, 28 Jun 2022 16:09:06 -0700 Subject: [PATCH 3/6] Update Program.cs --- src/Tools/dotnet-dump/Program.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tools/dotnet-dump/Program.cs b/src/Tools/dotnet-dump/Program.cs index 408f4b3287..6d162f8c45 100644 --- a/src/Tools/dotnet-dump/Program.cs +++ b/src/Tools/dotnet-dump/Program.cs @@ -108,7 +108,7 @@ private static Argument DumpPath() => private static Option RunCommand() => new Option( aliases: new[] { "-c", "--command" }, - description: "Runs the command on start. Multiple instances of this parameter can be used in an invocation to chain commands. They will get run in the order that they are provided on the commandline.") + description: "Runs the command on start. Multiple instances of this parameter can be used in an invocation to chain commands. Commands will get run in the order that they are provided on the commandline.") { Argument = new Argument(name: "command", getDefaultValue: () => Array.Empty()) { Arity = ArgumentArity.ZeroOrMore } }; From b757318dfada7ec90ce922f719109b8f57e33176 Mon Sep 17 00:00:00 2001 From: Juan Hoyos Date: Tue, 28 Jun 2022 16:10:14 -0700 Subject: [PATCH 4/6] Update Program.cs --- src/Tools/dotnet-dump/Program.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tools/dotnet-dump/Program.cs b/src/Tools/dotnet-dump/Program.cs index 6d162f8c45..083678f561 100644 --- a/src/Tools/dotnet-dump/Program.cs +++ b/src/Tools/dotnet-dump/Program.cs @@ -108,7 +108,7 @@ private static Argument DumpPath() => private static Option RunCommand() => new Option( aliases: new[] { "-c", "--command" }, - description: "Runs the command on start. Multiple instances of this parameter can be used in an invocation to chain commands. Commands will get run in the order that they are provided on the commandline.") + description: "Runs the command on start. Multiple instances of this parameter can be used in an invocation to chain commands. Commands will get run in the order that they are provided on the command line.") { Argument = new Argument(name: "command", getDefaultValue: () => Array.Empty()) { Arity = ArgumentArity.ZeroOrMore } }; From 2cd2b8927e71dbbc701eaefd8a5240ed011c37b9 Mon Sep 17 00:00:00 2001 From: Juan Hoyos Date: Tue, 28 Jun 2022 16:12:03 -0700 Subject: [PATCH 5/6] Update Program.cs --- src/Tools/dotnet-dump/Program.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tools/dotnet-dump/Program.cs b/src/Tools/dotnet-dump/Program.cs index 083678f561..85b8ed02d4 100644 --- a/src/Tools/dotnet-dump/Program.cs +++ b/src/Tools/dotnet-dump/Program.cs @@ -108,7 +108,7 @@ private static Argument DumpPath() => private static Option RunCommand() => new Option( aliases: new[] { "-c", "--command" }, - description: "Runs the command on start. Multiple instances of this parameter can be used in an invocation to chain commands. Commands will get run in the order that they are provided on the command line.") + description: "Runs the command on start. Multiple instances of this parameter can be used in an invocation to chain commands. Commands will get run in the order that they are provided on the command line. If you want to exit analysis after the commands, you must explicitly add an 'exit' command at the end.") { Argument = new Argument(name: "command", getDefaultValue: () => Array.Empty()) { Arity = ArgumentArity.ZeroOrMore } }; From fc5fd78c7d431addaf9a75281f700b793b05e11d Mon Sep 17 00:00:00 2001 From: Juan Hoyos Date: Tue, 28 Jun 2022 20:56:13 -0700 Subject: [PATCH 6/6] Update src/Tools/dotnet-dump/Program.cs Co-authored-by: Dan Moseley --- src/Tools/dotnet-dump/Program.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Tools/dotnet-dump/Program.cs b/src/Tools/dotnet-dump/Program.cs index 85b8ed02d4..c009e7a679 100644 --- a/src/Tools/dotnet-dump/Program.cs +++ b/src/Tools/dotnet-dump/Program.cs @@ -108,7 +108,7 @@ private static Argument DumpPath() => private static Option RunCommand() => new Option( aliases: new[] { "-c", "--command" }, - description: "Runs the command on start. Multiple instances of this parameter can be used in an invocation to chain commands. Commands will get run in the order that they are provided on the command line. If you want to exit analysis after the commands, you must explicitly add an 'exit' command at the end.") + description: "Runs the command on start. Multiple instances of this parameter can be used in an invocation to chain commands. Commands will get run in the order that they are provided on the command line. If you want to dotnet dump to exit after the commands, your last command should be 'exit'.") { Argument = new Argument(name: "command", getDefaultValue: () => Array.Empty()) { Arity = ArgumentArity.ZeroOrMore } };