Skip to content

chore: fix CI error of plantuml tests#10528

Merged
yufeih merged 1 commit into
dotnet:mainfrom
filzrev:chore-fix-ci-error-by-plantuml
Feb 18, 2025
Merged

chore: fix CI error of plantuml tests#10528
yufeih merged 1 commit into
dotnet:mainfrom
filzrev:chore-fix-ci-error-by-plantuml

Conversation

@filzrev
Copy link
Copy Markdown
Collaborator

@filzrev filzrev commented Feb 1, 2025

This PR intended to fix folowing nightly CI build issue.

Reported error content

Expected: hello</text><!--SRC=[SyfFKj2rKt3CoKnELR1Io4ZDoSa70000]--></g></svg></div>
Actual:   hello</text></g><!--SRC=[SyfFKj2rKt3CoKnELR1Io4ZDoSa70000]--></g></svg></div>

PlantUML Online Server related tests are frequently broken by server update.
And remaining test don't validate SVG content. it validate header/footer only. (#9858)
So I've changed test code to skip by default.

@filzrev
Copy link
Copy Markdown
Collaborator Author

filzrev commented Feb 4, 2025

@yufeih
Is it able to review & merge this PR with higher priority?
Because PR that created by depentabot are failed.

@yufeih yufeih merged commit f99ba39 into dotnet:main Feb 18, 2025
filzrev added a commit to filzrev/docfx that referenced this pull request Feb 18, 2025
chore: fix ci error of plantuml test
filzrev added a commit to filzrev/docfx that referenced this pull request Feb 18, 2025
chore: fix ci error of plantuml test
filzrev added a commit to filzrev/docfx that referenced this pull request Mar 1, 2025
chore: fix ci error of plantuml test
filzrev added a commit to filzrev/docfx that referenced this pull request May 27, 2025
chore: fix ci error of plantuml test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants