chore: Add custom file copy logics for template files#9369
Merged
yufeih merged 2 commits intoNov 2, 2023
Conversation
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
0658a9e to
eaa7a45
Compare
|
Starting from .NET 7.0, File.Copy can make a copy-on-write clone on some file systems, consuming less time and disk space than a full copy of the file content. That is thus a good change even if the copy cannot be skipped entirely. |
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
chore: add fast template file copy path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intended to resolve #9183 issue.
When running
docfx buildcommand with multiple times.There are unnecessaries operations that overwrite identical files.
This PR add features to skip this operations when template files is not changed.
It's required when using something like
dotnet watchscenarios.What's included in this PR
File::CopyAPI to preserve originalLastWriteTime.PreallocationSizesettings forFileStreamBenchmark Results
I've tested on
samples/seedproject and measuringTemplateProcessor::CopyTemplateResourceselapsed times.86.7[ms] ->8.0[ms])copy new fileandoverwrite files.It's running slightly slower about 10% (e.g.
86.7[ms] ->96.4[ms])I thought it's because of following reasons
File.CopyAPI requires additional operations (e.g. file's attribute copy)File::Copy)