pref: Optimize xrefmap download performance#9637
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9637 +/- ##
==========================================
- Coverage 74.31% 74.30% -0.01%
==========================================
Files 536 536
Lines 23173 23177 +4
Branches 4054 4054
==========================================
+ Hits 17220 17221 +1
- Misses 4851 4853 +2
- Partials 1102 1103 +1 ☔ View full report in Codecov by Sentry. |
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
pref: optimize xrefmap download perforamance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to resolve #9558
What's included in this PR
80KBis default buffer size that used byStream::CopyTo.What's tested
I've manually tested xrefmap download with following configuration.
And confirmed server returns following HTTP Response headers. And download size is reduced. (
316MB->16MB)TODO Tasks
I'll create another PR later relating #9558.
(Because YamlDotNet based JsonDeserializer is 5x slower than
System.Text.Jsonbased deserialization)xrefmap compressed by gzip(xrefmap.json.gz) from local disk.