Description
Versions affected: 9.0 RC1 and 8.0.9 servicing.
See dotnet/runtime#102204.
When using the FromKeyedServicesAttribute to specify a keyed service to be injected, an incorrect service may be passed.
Version
Other (please put exact version in description textbox)
Previous behavior
When a keyed service is intended to be injected as a parameter in a service constructor by using the FromKeyedServicesAttribute such as:
public MyService([FromKeyedServices("service1")] IService service1, ...and the corresponding keyed service ("service1" in this example) was not registered as a keyed service but was registered as a non-keyed service Type (IService in this example), then the non-keyed service is incorrectly injected instead of throwing an exception.
New behavior
An InvalidOperationException is now thrown when the FromKeyedServicesAttribute is used and the specified keyed service was not found; this is consistent with other cases when the requested service cannot be found due to lack of registration.
Type of breaking change
Reason for change
Adds missing validation logic to detect service misconfiguration bugs; this issue existed when the keyed service feature was added in v8.0.
Recommended action
If FromKeyedServicesAttribute is used, ensure that the corresponding service is registered as a keyed service, such as by using IServiceCollection.AddKeyedScoped(), IServiceCollection.AddKeyedSingleton() or IServiceCollection.AddKeyedTransient().
The fix will be backported to v8.0.9 so both v9.0 and v8.0 have the same behavior. If your application depends on the old behavior, a feature switch was added for v8.0.9 (but not v9.0) named "Microsoft.Extensions.DependencyInjection.AllowNonKeyedServiceInject" that if set to "true" will keep the old behavior.
Feature area
Containers, Core .NET libraries
Affected APIs
Microsoft.Extensions.DependencyInjection.FromKeyedServicesAttribute(object key) constructor
Associated WorkItem - 302333
Description
Versions affected: 9.0 RC1 and 8.0.9 servicing.
See dotnet/runtime#102204.
When using the
FromKeyedServicesAttributeto specify a keyed service to be injected, an incorrect service may be passed.Version
Other (please put exact version in description textbox)
Previous behavior
When a keyed service is intended to be injected as a parameter in a service constructor by using the
FromKeyedServicesAttributesuch as:and the corresponding keyed service ("service1" in this example) was not registered as a keyed service but was registered as a non-keyed service Type (
IServicein this example), then the non-keyed service is incorrectly injected instead of throwing an exception.New behavior
An
InvalidOperationExceptionis now thrown when theFromKeyedServicesAttributeis used and the specified keyed service was not found; this is consistent with other cases when the requested service cannot be found due to lack of registration.Type of breaking change
Reason for change
Adds missing validation logic to detect service misconfiguration bugs; this issue existed when the keyed service feature was added in v8.0.
Recommended action
If
FromKeyedServicesAttributeis used, ensure that the corresponding service is registered as a keyed service, such as by usingIServiceCollection.AddKeyedScoped(),IServiceCollection.AddKeyedSingleton()orIServiceCollection.AddKeyedTransient().The fix will be backported to v8.0.9 so both v9.0 and v8.0 have the same behavior. If your application depends on the old behavior, a feature switch was added for v8.0.9 (but not v9.0) named "Microsoft.Extensions.DependencyInjection.AllowNonKeyedServiceInject" that if set to "true" will keep the old behavior.
Feature area
Containers, Core .NET libraries
Affected APIs
Microsoft.Extensions.DependencyInjection.FromKeyedServicesAttribute(object key) constructor
Associated WorkItem - 302333