From 21db1127a8c7e4e3e91d72c014b384242ad9de8e Mon Sep 17 00:00:00 2001 From: Robin Lindner Date: Mon, 13 Dec 2021 19:53:17 +0100 Subject: [PATCH 1/8] Update JsonNumberHandling.xml --- xml/System.Text.Json.Serialization/JsonNumberHandling.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml index e1fee5834c2..f9cd3837e18 100644 --- a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml +++ b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml @@ -21,7 +21,7 @@ Determines how handles numbers when serializing and deserializing. - To be added. + You can do this, but you need to be aware that this will create potentially non-interoperable JSON. @@ -109,7 +109,7 @@ 2 Numbers will be written as JSON strings (with quotes), not as JSON numbers. - To be added. + You can do this, but you need to be aware that this will create potentially non-interoperable JSON. From 09741169e939858946515d0501990ca26f8db332 Mon Sep 17 00:00:00 2001 From: Robin Lindner Date: Tue, 14 Dec 2021 18:24:32 +0100 Subject: [PATCH 2/8] Usage of more insightful remark --- xml/System.Text.Json.Serialization/JsonNumberHandling.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml index f9cd3837e18..b621cfb1c3d 100644 --- a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml +++ b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml @@ -21,7 +21,7 @@ Determines how handles numbers when serializing and deserializing. - You can do this, but you need to be aware that this will create potentially non-interoperable JSON. + Mentioned values are not defined by the specification. Using this setting may potentially produce JSON which may be non-parsable in other JSON implementations. @@ -109,7 +109,7 @@ 2 Numbers will be written as JSON strings (with quotes), not as JSON numbers. - You can do this, but you need to be aware that this will create potentially non-interoperable JSON. + Mentioned values are not defined by the specification. Using this setting may potentially produce JSON which may be non-parsable in other JSON implementations. From 99488ed471f8330c5539456b04e90ba961f7ee81 Mon Sep 17 00:00:00 2001 From: Robin Lindner Date: Wed, 15 Dec 2021 08:12:04 +0100 Subject: [PATCH 3/8] Simplify wording --- xml/System.Text.Json.Serialization/JsonNumberHandling.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml index b621cfb1c3d..865072126f2 100644 --- a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml +++ b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml @@ -21,7 +21,7 @@ Determines how handles numbers when serializing and deserializing. - Mentioned values are not defined by the specification. Using this setting may potentially produce JSON which may be non-parsable in other JSON implementations. + Mentioned values are not defined by the specification. Using this setting may potentially produce JSON which may produce JSON which cannot be parsed by other JSON implementations. @@ -109,7 +109,7 @@ 2 Numbers will be written as JSON strings (with quotes), not as JSON numbers. - Mentioned values are not defined by the specification. Using this setting may potentially produce JSON which may be non-parsable in other JSON implementations. + Mentioned values are not defined by the specification. Using this setting may potentially produce JSON which may produce JSON which cannot be parsed by other JSON implementations. From 138f228266d12bc2b3973f20e73c9798bf4d7c84 Mon Sep 17 00:00:00 2001 From: Robin Lindner Date: Sat, 18 Dec 2021 22:46:10 +0100 Subject: [PATCH 4/8] Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --- xml/System.Text.Json.Serialization/JsonNumberHandling.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml index 865072126f2..b65dbac4136 100644 --- a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml +++ b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml @@ -21,7 +21,7 @@ Determines how handles numbers when serializing and deserializing. - Mentioned values are not defined by the specification. Using this setting may potentially produce JSON which may produce JSON which cannot be parsed by other JSON implementations. + The fields of this enumeration are not defined by the JSON specification. Altering the default number handling can potentially produce JSON that cannot be parsed by other JSON implementations. From fcd18628179a07a711f5e09a94131c631825075c Mon Sep 17 00:00:00 2001 From: Robin Lindner Date: Sat, 18 Dec 2021 22:47:51 +0100 Subject: [PATCH 5/8] Update remark --- xml/System.Text.Json.Serialization/JsonNumberHandling.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml index b65dbac4136..65aa4bb2347 100644 --- a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml +++ b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml @@ -109,7 +109,7 @@ 2 Numbers will be written as JSON strings (with quotes), not as JSON numbers. - Mentioned values are not defined by the specification. Using this setting may potentially produce JSON which may produce JSON which cannot be parsed by other JSON implementations. + The fields of this enumeration are not defined by the JSON specification. Altering the default number handling can potentially produce JSON that cannot be parsed by other JSON implementations. From 4c70e4af26d42c42c58d2c83a4f2b61869c6aaee Mon Sep 17 00:00:00 2001 From: Robin Lindner Date: Mon, 20 Dec 2021 20:14:46 +0100 Subject: [PATCH 6/8] Move remark and change wording --- xml/System.Text.Json.Serialization/JsonNumberHandling.xml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml index 65aa4bb2347..dada2c10bf9 100644 --- a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml +++ b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml @@ -21,7 +21,6 @@ Determines how handles numbers when serializing and deserializing. - The fields of this enumeration are not defined by the JSON specification. Altering the default number handling can potentially produce JSON that cannot be parsed by other JSON implementations. @@ -43,7 +42,7 @@ 4 The "NaN", "Infinity", and "-Infinity" tokens can be read as floating-point constants, and the and values for these constants will be written as their corresponding JSON string representations. - To be added. + This field is not defined by the JSON specification. Altering the default number handling can potentially produce JSON that cannot be parsed by other JSON implementations. @@ -109,7 +108,7 @@ 2 Numbers will be written as JSON strings (with quotes), not as JSON numbers. - The fields of this enumeration are not defined by the JSON specification. Altering the default number handling can potentially produce JSON that cannot be parsed by other JSON implementations. + TThis field is not defined by the JSON specification. Altering the default number handling can potentially produce JSON that cannot be parsed by other JSON implementations. From 48502c802ce508e46055f021b8120e8933e38ce3 Mon Sep 17 00:00:00 2001 From: Robin Lindner Date: Mon, 20 Dec 2021 20:15:13 +0100 Subject: [PATCH 7/8] Fix typo --- xml/System.Text.Json.Serialization/JsonNumberHandling.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml index dada2c10bf9..7962421429e 100644 --- a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml +++ b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml @@ -108,7 +108,7 @@ 2 Numbers will be written as JSON strings (with quotes), not as JSON numbers. - TThis field is not defined by the JSON specification. Altering the default number handling can potentially produce JSON that cannot be parsed by other JSON implementations. + This field is not defined by the JSON specification. Altering the default number handling can potentially produce JSON that cannot be parsed by other JSON implementations. From ae2a9ee321ba4cf0fb2605c605878bbf14c36ae6 Mon Sep 17 00:00:00 2001 From: Robin Lindner Date: Wed, 22 Dec 2021 22:37:17 +0100 Subject: [PATCH 8/8] Add enum-lvl remark --- xml/System.Text.Json.Serialization/JsonNumberHandling.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml index 7962421429e..49572c04410 100644 --- a/xml/System.Text.Json.Serialization/JsonNumberHandling.xml +++ b/xml/System.Text.Json.Serialization/JsonNumberHandling.xml @@ -21,6 +21,7 @@ Determines how handles numbers when serializing and deserializing. + The behavior of and is not defined by the JSON specification. Altering the default number handling can potentially produce JSON that cannot be parsed by other JSON implementations.