Remove orphaned copy of a test file#19886
Merged
Merged
Conversation
SkipLocalsInit.fs file exisits in two different folders and only one of the copies is actually included in the project.
Contributor
✅ No release notes required |
github-actions
Bot
added
the
AI-Tooling-Check-Scanned-Clean
T-Gro
approved these changes
Jun 3, 2026
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
Bot
moved this from In Progress
to Done
in F# Compiler and Tooling
T-Gro
pushed a commit
that referenced
this pull request
Jun 3, 2026
…changes The previous optimizer change fired on ALL unused effectful let-bindings, which was too broad and caused TailCall attribute test failures, EmittedIL Desktop baseline mismatches, and other CI issues. Narrow the condition to only fire when the bound variable has IsMemberThisVal, which is the specific case from issue #13099 where state-machine lowering drops a side-effectful receiver expression. Also remove tests/FSharp.Compiler.ComponentTests/SkipLocalsInit.fs which was deleted on main in PR #19886. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkipLocalsInit.fsfile exists in two different folders and only one of the copies is actually included in the test project.This confuses AI agents.